Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: sync/internal_api/public/base/ordinal_unittest.cc

Issue 1477433005: Remove kuint8max. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@kint4
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/public/base/node_ordinal.h ('k') | sync/internal_api/public/base/unique_position.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/public/base/ordinal_unittest.cc
diff --git a/sync/internal_api/public/base/ordinal_unittest.cc b/sync/internal_api/public/base/ordinal_unittest.cc
index 7401e836583f927edee4f0b907bcaa74319edeeb..f4296ccc0c2ec25771179f7e065f0c7e213424cd 100644
--- a/sync/internal_api/public/base/ordinal_unittest.cc
+++ b/sync/internal_api/public/base/ordinal_unittest.cc
@@ -2,9 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "base/basictypes.h"
#include "sync/internal_api/public/base/ordinal.h"
-#include "testing/gtest/include/gtest/gtest.h"
+
+#include <stdint.h>
#include <algorithm>
#include <cctype>
@@ -12,25 +12,27 @@
#include <string>
#include <vector>
+#include "testing/gtest/include/gtest/gtest.h"
+
namespace syncer {
namespace {
struct TestOrdinalTraits {
- static const uint8 kZeroDigit = '0';
- static const uint8 kMaxDigit = '3';
+ static const uint8_t kZeroDigit = '0';
+ static const uint8_t kMaxDigit = '3';
static const size_t kMinLength = 1;
};
struct LongOrdinalTraits {
- static const uint8 kZeroDigit = '0';
- static const uint8 kMaxDigit = '9';
+ static const uint8_t kZeroDigit = '0';
+ static const uint8_t kMaxDigit = '9';
static const size_t kMinLength = 5;
};
struct LargeOrdinalTraits {
- static const uint8 kZeroDigit = 0;
- static const uint8 kMaxDigit = kuint8max;
+ static const uint8_t kZeroDigit = 0;
+ static const uint8_t kMaxDigit = UINT8_MAX;
static const size_t kMinLength = 1;
};
« no previous file with comments | « sync/internal_api/public/base/node_ordinal.h ('k') | sync/internal_api/public/base/unique_position.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698