Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1472083005: Remove kint64min. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, maxbogue+watch_chromium.org, imcheng+watch_chromium.org, zea+watch_chromium.org, tzik, jasonroberts+watch_google.com, vmpstr+watch_chromium.org, avayvod+watch_chromium.org, nhiroki, isheriff+watch_chromium.org, feature-media-reviews_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, eme-reviews_chromium.org, xjz+watch_chromium.org, kinuko+fileapi, jshin+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@kint5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove kint64min. BUG=138542 Committed: https://crrev.com/7e3976acf2547251b34ca0aebf1428d72d3e5985 Cr-Commit-Position: refs/heads/master@{#362995}

Patch Set 1 #

Total comments: 8

Patch Set 2 : rebase, fixes #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+725 lines, -793 lines) Patch
M base/android/jni_array_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/basictypes.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/json/json_writer.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M base/strings/string_number_conversions_unittest.cc View 13 chunks +209 lines, -201 lines 0 comments Download
M chrome/browser/net/url_info.cc View 3 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M components/invalidation/impl/fake_invalidation_state_tracker.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/invalidation/impl/fake_invalidation_state_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/timestamp_constants.h View 2 chunks +5 lines, -1 line 0 comments Download
M media/cast/net/rtcp/rtcp.h View 1 2 10 chunks +30 lines, -29 lines 0 comments Download
M media/cast/net/rtcp/rtcp.cc View 1 2 11 chunks +36 lines, -34 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.h View 7 chunks +23 lines, -21 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 1 2 16 chunks +38 lines, -37 lines 0 comments Download
M media/formats/mp4/track_run_iterator.h View 6 chunks +16 lines, -13 lines 0 comments Download
M media/formats/mp4/track_run_iterator.cc View 19 chunks +58 lines, -49 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 1 2 3 4 9 chunks +176 lines, -326 lines 0 comments Download
M sync/internal_api/public/base/node_ordinal_unittest.cc View 1 5 chunks +54 lines, -33 lines 0 comments Download
M sync/internal_api/public/base/unique_position_unittest.cc View 6 chunks +48 lines, -30 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 36 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472083005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472083005/1
5 years ago (2015-11-25 16:34:51 UTC) #2
Avi (use Gerrit)
mark: base/ mmenke: chrome/browser/net and net/ tzik: chrome/browser/sync_file_system pavely: components/invalidation and sync/ dalecurtis: media/
5 years ago (2015-11-25 18:01:43 UTC) #4
Mark Mentovai
LGTM
5 years ago (2015-11-25 18:14:08 UTC) #5
pavely
components/invalidation/*, sync/*: lgtm with small comment. https://codereview.chromium.org/1472083005/diff/1/sync/internal_api/public/base/node_ordinal_unittest.cc File sync/internal_api/public/base/node_ordinal_unittest.cc (right): https://codereview.chromium.org/1472083005/diff/1/sync/internal_api/public/base/node_ordinal_unittest.cc#newcode19 sync/internal_api/public/base/node_ordinal_unittest.cc:19: const int64 kTestValues[] ...
5 years ago (2015-11-25 18:24:36 UTC) #6
Avi (use Gerrit)
https://codereview.chromium.org/1472083005/diff/1/sync/internal_api/public/base/node_ordinal_unittest.cc File sync/internal_api/public/base/node_ordinal_unittest.cc (right): https://codereview.chromium.org/1472083005/diff/1/sync/internal_api/public/base/node_ordinal_unittest.cc#newcode19 sync/internal_api/public/base/node_ordinal_unittest.cc:19: const int64 kTestValues[] = {0LL, On 2015/11/25 18:24:36, pavely ...
5 years ago (2015-11-25 18:30:13 UTC) #7
mmenke
net, content/browser/net LGTM https://codereview.chromium.org/1472083005/diff/1/net/http/http_response_headers_unittest.cc File net/http/http_response_headers_unittest.cc (right): https://codereview.chromium.org/1472083005/diff/1/net/http/http_response_headers_unittest.cc#newcode1271 net/http/http_response_headers_unittest.cc:1271: -1}, I assume this is just ...
5 years ago (2015-11-25 18:33:46 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 18:35:10 UTC) #10
Avi (use Gerrit)
https://codereview.chromium.org/1472083005/diff/1/net/http/http_response_headers_unittest.cc File net/http/http_response_headers_unittest.cc (right): https://codereview.chromium.org/1472083005/diff/1/net/http/http_response_headers_unittest.cc#newcode1271 net/http/http_response_headers_unittest.cc:1271: -1}, On 2015/11/25 18:33:46, mmenke wrote: > I assume ...
5 years ago (2015-11-25 18:39:13 UTC) #11
DaleCurtis
media/ lgtm % nit? https://codereview.chromium.org/1472083005/diff/1/media/cdm/ppapi/external_clear_key/clear_key_cdm.cc File media/cdm/ppapi/external_clear_key/clear_key_cdm.cc (right): https://codereview.chromium.org/1472083005/diff/1/media/cdm/ppapi/external_clear_key/clear_key_cdm.cc#newcode27 media/cdm/ppapi/external_clear_key/clear_key_cdm.cc:27: const int64_t kNoTimestamp = INT64_t_MIN; ...
5 years ago (2015-11-25 18:52:25 UTC) #12
Avi (use Gerrit)
https://codereview.chromium.org/1472083005/diff/1/media/cdm/ppapi/external_clear_key/clear_key_cdm.cc File media/cdm/ppapi/external_clear_key/clear_key_cdm.cc (right): https://codereview.chromium.org/1472083005/diff/1/media/cdm/ppapi/external_clear_key/clear_key_cdm.cc#newcode27 media/cdm/ppapi/external_clear_key/clear_key_cdm.cc:27: const int64_t kNoTimestamp = INT64_t_MIN; On 2015/11/25 18:52:25, DaleCurtis ...
5 years ago (2015-11-25 19:03:23 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472083005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472083005/20001
5 years ago (2015-11-25 21:40:49 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ...
5 years ago (2015-11-25 23:47:01 UTC) #17
tzik
lgtm
5 years ago (2015-11-26 03:55:50 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472083005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472083005/40001
5 years ago (2015-12-01 21:48:44 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/101372) mac_chromium_compile_dbg_ng on ...
5 years ago (2015-12-01 21:54:55 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472083005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472083005/60001
5 years ago (2015-12-02 00:37:57 UTC) #24
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 02:49:39 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472083005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472083005/80001
5 years ago (2015-12-02 17:17:45 UTC) #28
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 20:24:19 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472083005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472083005/80001
5 years ago (2015-12-03 16:41:28 UTC) #33
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-12-03 16:47:03 UTC) #34
commit-bot: I haz the power
5 years ago (2015-12-03 16:48:00 UTC) #36
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7e3976acf2547251b34ca0aebf1428d72d3e5985
Cr-Commit-Position: refs/heads/master@{#362995}

Powered by Google App Engine
This is Rietveld 408576698