Make whether or not a Code object should be created by masm explicit

Make whether or not a Code object should be created by masm explicit

We always want to have an Isolate, so just use an extra ctor arg

BUG=2487
R=yangguo@chromium.org,mstarzinger@chromium.org
LOG=n

Committed: https://crrev.com/aa9cfc822225e18f38c75033f5c88012ea206c32
Cr-Commit-Position: refs/heads/master@{#32277}

[jochen (gone - plz use gerrit), 2015-11-25 09:31:27]

ptal

I'm also added the isolate at the callsites where it was trivially available

[Yang, 2015-11-25 10:49:29]

lgtm

[Yang, 2015-11-25 10:51:12]

On 2015/11/25 10:49:29, Yang wrote:
> lgtm

methinks you still need owners for src/ic and src/crankshaft.

[jochen (gone - plz use gerrit), 2015-11-25 10:53:03]

jochen@chromium.org changed reviewers:
+ jkummerow@chromium.org

[jochen (gone - plz use gerrit), 2015-11-25 10:53:04]

+jkummerow ptal

[Toon Verwaest, 2015-11-25 10:55:50]

verwaest@chromium.org changed reviewers:
+ verwaest@chromium.org

[Toon Verwaest, 2015-11-25 10:55:50]

Could you turn that into an enum?

[Michael Starzinger, 2015-11-25 11:31:57]

https://codereview.chromium.org/1476763002/diff/20001/src/arm/macro-assembler...
File src/arm/macro-assembler-arm.h (right):

https://codereview.chromium.org/1476763002/diff/20001/src/arm/macro-assembler...
src/arm/macro-assembler-arm.h:92: bool create_code_object);
Random boolean argument is being random. Can we make that an enum instead? Also
I would be fine with a default argument for "do generate code" here.

[Jakob Kummerow, 2015-11-25 11:46:49]

src/ic/* and src/crankshaft/* LGTM if you address Toon's/Michi's comment.

[jochen (gone - plz use gerrit), 2015-11-25 12:31:36]

ptal

[Michael Starzinger, 2015-11-25 14:10:57]

LGTM from my end.

[jochen (gone - plz use gerrit), 2015-11-25 14:12:15]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-11-25 14:12:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
yangguo@chromium.org, jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1476763002/#ps40001
(title: "enum class FTW")

[commit-bot: I haz the power, 2015-11-25 14:12:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476763002/40001

[commit-bot: I haz the power, 2015-11-25 14:23:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-25 14:24:05]

Patchset 3 (id:??) landed as
https://crrev.com/aa9cfc822225e18f38c75033f5c88012ea206c32
Cr-Commit-Position: refs/heads/master@{#32277}