src/regexp/x87/regexp-macro-assembler-x87.cc - Issue 1476763002: Make whether or not a Code object should be created by masm explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/regexp/x87/regexp-macro-assembler-x87.cc

Issue 1476763002: Make whether or not a Code object should be created by masm explicit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: enum class FTW Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/regexp/x87/regexp-macro-assembler-x87.cc

diff --git a/src/regexp/x87/regexp-macro-assembler-x87.cc b/src/regexp/x87/regexp-macro-assembler-x87.cc

index 1473c75f40be73942c1eec89687e27dd9838e277..01d0b249b6fe15b9f0d56e65742d6b0d6910c5f9 100644

--- a/src/regexp/x87/regexp-macro-assembler-x87.cc

+++ b/src/regexp/x87/regexp-macro-assembler-x87.cc

@@ -81,7 +81,8 @@ RegExpMacroAssemblerX87::RegExpMacroAssemblerX87(Isolate* isolate, Zone* zone,

Mode mode,

int registers_to_save)

: NativeRegExpMacroAssembler(isolate, zone),

- masm_(new MacroAssembler(isolate, NULL, kRegExpCodeSize)),

+ masm_(new MacroAssembler(isolate, NULL, kRegExpCodeSize,

+ CodeObjectRequired::kYes)),

mode_(mode),

num_registers_(registers_to_save),

num_saved_registers_(registers_to_save),

« no previous file with comments | « src/regexp/x64/regexp-macro-assembler-x64.cc ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »