Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: src/ic/access-compiler.h

Issue 1476763002: Make whether or not a Code object should be created by masm explicit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: enum class FTW Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/mips/code-stubs-mips.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_IC_ACCESS_COMPILER_H_ 5 #ifndef V8_IC_ACCESS_COMPILER_H_
6 #define V8_IC_ACCESS_COMPILER_H_ 6 #define V8_IC_ACCESS_COMPILER_H_
7 7
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/macro-assembler.h" 9 #include "src/macro-assembler.h"
10 #include "src/objects.h" 10 #include "src/objects.h"
(...skipping 22 matching lines...) Expand all
33 33
34 static void TailCallBuiltin(MacroAssembler* masm, Builtins::Name name); 34 static void TailCallBuiltin(MacroAssembler* masm, Builtins::Name name);
35 35
36 protected: 36 protected:
37 PropertyAccessCompiler(Isolate* isolate, Code::Kind kind, 37 PropertyAccessCompiler(Isolate* isolate, Code::Kind kind,
38 CacheHolderFlag cache_holder) 38 CacheHolderFlag cache_holder)
39 : registers_(GetCallingConvention(kind)), 39 : registers_(GetCallingConvention(kind)),
40 kind_(kind), 40 kind_(kind),
41 cache_holder_(cache_holder), 41 cache_holder_(cache_holder),
42 isolate_(isolate), 42 isolate_(isolate),
43 masm_(isolate, NULL, 256) { 43 masm_(isolate, NULL, 256, CodeObjectRequired::kYes) {
44 // TODO(yangguo): remove this once we can serialize IC stubs. 44 // TODO(yangguo): remove this once we can serialize IC stubs.
45 masm_.enable_serializer(); 45 masm_.enable_serializer();
46 } 46 }
47 47
48 Code::Kind kind() const { return kind_; } 48 Code::Kind kind() const { return kind_; }
49 CacheHolderFlag cache_holder() const { return cache_holder_; } 49 CacheHolderFlag cache_holder() const { return cache_holder_; }
50 MacroAssembler* masm() { return &masm_; } 50 MacroAssembler* masm() { return &masm_; }
51 Isolate* isolate() const { return isolate_; } 51 Isolate* isolate() const { return isolate_; }
52 Heap* heap() const { return isolate()->heap(); } 52 Heap* heap() const { return isolate()->heap(); }
53 Factory* factory() const { return isolate()->factory(); } 53 Factory* factory() const { return isolate()->factory(); }
(...skipping 24 matching lines...) Expand all
78 78
79 Isolate* isolate_; 79 Isolate* isolate_;
80 MacroAssembler masm_; 80 MacroAssembler masm_;
81 // Ensure that MacroAssembler has a reasonable size. 81 // Ensure that MacroAssembler has a reasonable size.
82 STATIC_ASSERT(sizeof(MacroAssembler) < 128 * kPointerSize); 82 STATIC_ASSERT(sizeof(MacroAssembler) < 128 * kPointerSize);
83 }; 83 };
84 } // namespace internal 84 } // namespace internal
85 } // namespace v8 85 } // namespace v8
86 86
87 #endif // V8_IC_ACCESS_COMPILER_H_ 87 #endif // V8_IC_ACCESS_COMPILER_H_
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/mips/code-stubs-mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698