src/deoptimizer.cc - Issue 1476763002: Make whether or not a Code object should be created by masm explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/deoptimizer.cc

Issue 1476763002: Make whether or not a Code object should be created by masm explicit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: enum class FTW Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/deoptimizer.cc

diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc

index 0dcb16674f3bbb0b10cdd9d406c54128a54ca493..dc50cb93cdb056588a4b4ecdf54d9797c9da7ae1 100644

--- a/src/deoptimizer.cc

+++ b/src/deoptimizer.cc

@@ -1831,7 +1831,7 @@ void Deoptimizer::EnsureCodeForDeoptimizationEntry(Isolate* isolate,

while (max_entry_id >= entry_count) entry_count *= 2;

CHECK(entry_count <= Deoptimizer::kMaxNumberOfEntries);

- MacroAssembler masm(isolate, NULL, 16 * KB);

+ MacroAssembler masm(isolate, NULL, 16 * KB, CodeObjectRequired::kYes);

masm.set_emit_debug_code(false);

GenerateDeoptimizationEntries(&masm, entry_count, type);

CodeDesc desc;

« no previous file with comments | « src/crankshaft/lithium.cc ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »