mustash: Enable connections to mus from the Chrome renderer [take 2]

mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a
RenderWidgetWindowTreeClientFactory interface from the renderer. It
uses that client ptr to issue an CreateWindowTreeClientForRenderWidget
with the host routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for
RenderWidgetWindowTreeClientFactory and handles it in
RenderWidgetWindowTreeClientFactoryImpl. The renderer sees
the subsequent CreateWindowTreeClientForRenderWidget call, and
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient
interface request to establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus
with a mus::Window as its root and starts putting things
on screen inside this window.

BUG=551250
Committed: https://crrev.com/6c6da0233c011d29cc7c43221fb8f5482405dfb6
Cr-Commit-Position: refs/heads/master@{#361820}

[Fady Samuel, 2015-11-25 03:15:52]

Description was changed from

==========
Sad mustash

BUG=
==========

to

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a RenderProcessClient 
interface from the renderer. It uses that client ptr to 
issue an OnRenderWidgetHostViewcreated with the host 
routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderProcessClient and handles it in 
RenderProcessClientConnectionListener. The renderer sees 
the subsequent OnRenderWidgetHostViewCreated call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient interface request to
establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root.

BUG=
==========

[Fady Samuel, 2015-11-25 03:16:11]

Description was changed from

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a RenderProcessClient 
interface from the renderer. It uses that client ptr to 
issue an OnRenderWidgetHostViewcreated with the host 
routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderProcessClient and handles it in 
RenderProcessClientConnectionListener. The renderer sees 
the subsequent OnRenderWidgetHostViewCreated call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient interface request to
establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root.

BUG=
==========

to

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a RenderProcessClient 
interface from the renderer. It uses that client ptr to 
issue an OnRenderWidgetHostViewcreated with the host 
routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderProcessClient and handles it in 
RenderProcessClientConnectionListener. The renderer sees 
the subsequent OnRenderWidgetHostViewCreated call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient interface request to
establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root.

BUG=551250
==========

[Fady Samuel, 2015-11-25 03:16:58]

Description was changed from

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a RenderProcessClient 
interface from the renderer. It uses that client ptr to 
issue an OnRenderWidgetHostViewcreated with the host 
routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderProcessClient and handles it in 
RenderProcessClientConnectionListener. The renderer sees 
the subsequent OnRenderWidgetHostViewCreated call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient interface request to
establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root.

BUG=551250
==========

to

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a RenderProcessClient 
interface from the renderer. It uses that client ptr to 
issue an OnRenderWidgetHostViewcreated with the host 
routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderProcessClient and handles it in 
RenderProcessClientConnectionListener. The renderer sees 
the subsequent OnRenderWidgetHostViewCreated call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient interface request to
establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root and starts putting things on screen inside this
window.

BUG=551250
==========

[Fady Samuel, 2015-11-25 03:18:05]

fsamuel@chromium.org changed reviewers:
+ ben@chromium.org

[Fady Samuel, 2015-11-25 03:54:53]

Description was changed from

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a RenderProcessClient 
interface from the renderer. It uses that client ptr to 
issue an OnRenderWidgetHostViewcreated with the host 
routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderProcessClient and handles it in 
RenderProcessClientConnectionListener. The renderer sees 
the subsequent OnRenderWidgetHostViewCreated call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient interface request to
establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root and starts putting things on screen inside this
window.

BUG=551250
==========

to

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a RenderProcessClient 
interface from the renderer. It uses that client ptr to 
issue an OnRenderWidgetHostViewcreated with the host 
routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderProcessClient and handles it in 
RenderProcessClientConnectionListener. The renderer sees 
the subsequent OnRenderWidgetHostViewCreated call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient 
interface request to establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root and starts putting things on screen inside this
window.

BUG=551250
==========

[Fady Samuel, 2015-11-25 03:55:10]

Description was changed from

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a RenderProcessClient 
interface from the renderer. It uses that client ptr to 
issue an OnRenderWidgetHostViewcreated with the host 
routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderProcessClient and handles it in 
RenderProcessClientConnectionListener. The renderer sees 
the subsequent OnRenderWidgetHostViewCreated call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient 
interface request to establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root and starts putting things on screen inside this
window.

BUG=551250
==========

to

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a RenderProcessClient 
interface from the renderer. It uses that client ptr to 
issue an OnRenderWidgetHostViewcreated with the host 
routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderProcessClient and handles it in 
RenderProcessClientConnectionListener. The renderer sees 
the subsequent OnRenderWidgetHostViewCreated call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient 
interface request to establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root and starts putting things 
on screen inside this window.

BUG=551250
==========

[Ben Goodger (Google), 2015-11-25 04:07:28]

https://codereview.chromium.org/1476643002/diff/60001/content/browser/mojo/mo...
File content/browser/mojo/mojo_shell_client_host.cc (right):

https://codereview.chromium.org/1476643002/diff/60001/content/browser/mojo/mo...
content/browser/mojo/mojo_shell_client_host.cc:111:
SetMojoPlatformFile(render_process_host, client_file);
Instead of structuring it this way, I'd do this:

- change SetMojoApplicationInstanceURL to just take a RPH
- have it generate & set the url on the RPH
- call it from the RPH ctor

then leave the rest of this function intact.

https://codereview.chromium.org/1476643002/diff/60001/content/browser/mus_util.h
File content/browser/mus_util.h (right):

https://codereview.chromium.org/1476643002/diff/60001/content/browser/mus_uti...
content/browser/mus_util.h:18: mus::Window* GetMusWindow(aura::Window* window);
this utility should probably live in ui/aura/mus, with a corresponding setter
functino

https://codereview.chromium.org/1476643002/diff/60001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_mus.cc (right):

https://codereview.chromium.org/1476643002/diff/60001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_mus.cc:112: std::string
url = GetMojoApplicationInstanceURL(host_->GetProcess());
just put this in the ctor since no one else calls it.

https://codereview.chromium.org/1476643002/diff/60001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/1476643002/diff/60001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:10: #include
"base/debug/stack_trace.h"
remove

https://codereview.chromium.org/1476643002/diff/60001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:422: //
base::debug::StackTrace().Print();
remove

https://codereview.chromium.org/1476643002/diff/60001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:540: 
undo

https://codereview.chromium.org/1476643002/diff/60001/content/child/child_thr...
File content/child/child_thread_impl.h (right):

https://codereview.chromium.org/1476643002/diff/60001/content/child/child_thr...
content/child/child_thread_impl.h:196: #if defined(MOJO_SHELL_CLIENT)
this is absolutely going to cause you pain, get rid of it.

Instead, I think we should probably separate creation of the MojoShellConnection
from binding it to a pipe. You can add a bare create method and call it early in
RendererMain(). That means we can add listeners early.

Then add two bind methods:
BindToMessagePipe
BindToCommandLinePlatformChannel

https://codereview.chromium.org/1476643002/diff/60001/content/common/render_p...
File content/common/render_process_client.mojom (right):

https://codereview.chromium.org/1476643002/diff/60001/content/common/render_p...
content/common/render_process_client.mojom:9: interface RenderProcessClient {
RenderWidgetWindowTreeClientFactory

https://codereview.chromium.org/1476643002/diff/60001/content/common/render_p...
content/common/render_process_client.mojom:11: mus.mojom.WindowTreeClient&
window_tree_client);
CreateWindowTreeClientForRenderWidget(uint32 routing_id, ...)

https://codereview.chromium.org/1476643002/diff/60001/content/public/browser/...
File content/public/browser/BUILD.gn (right):

https://codereview.chromium.org/1476643002/diff/60001/content/public/browser/...
content/public/browser/BUILD.gn:49: "//content/public/common:mojo_shell_client",
what do you need this for?

https://codereview.chromium.org/1476643002/diff/60001/content/renderer/render...
File content/renderer/render_process_client_connection_listener.cc (right):

https://codereview.chromium.org/1476643002/diff/60001/content/renderer/render...
content/renderer/render_process_client_connection_listener.cc:22: class
RenderProcessClientConnectionListener
RenderWidgetWindowTreeClientFactoryImpl

https://codereview.chromium.org/1476643002/diff/60001/content/renderer/render...
File content/renderer/render_process_client_connection_listener.h (right):

https://codereview.chromium.org/1476643002/diff/60001/content/renderer/render...
content/renderer/render_process_client_connection_listener.h:10: void
CreateRenderProcessClientConnectionListener();
CreateRenderWidgetWindowTreeClientFactory

https://codereview.chromium.org/1476643002/diff/60001/content/renderer/render...
File content/renderer/render_widget_mus_connection.h (right):

https://codereview.chromium.org/1476643002/diff/60001/content/renderer/render...
content/renderer/render_widget_mus_connection.h:40:
scoped_ptr<mojo::Binding<mus::mojom::WindowTreeClient>> binding_;
what is this used for?

https://codereview.chromium.org/1476643002/diff/60001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/1476643002/diff/60001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:185: content_->SetNativeWindowProperty("mus",
window_);
use the setter you defined in ui/aura/mus

[Fady Samuel, 2015-11-25 17:45:53]

PTAL Ben!

https://codereview.chromium.org/1476643002/diff/60001/content/browser/mojo/mo...
File content/browser/mojo/mojo_shell_client_host.cc (right):

https://codereview.chromium.org/1476643002/diff/60001/content/browser/mojo/mo...
content/browser/mojo/mojo_shell_client_host.cc:111:
SetMojoPlatformFile(render_process_host, client_file);
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> Instead of structuring it this way, I'd do this:
> 
> - change SetMojoApplicationInstanceURL to just take a RPH
> - have it generate & set the url on the RPH
> - call it from the RPH ctor
> 
> then leave the rest of this function intact.

I think this structuring is necessary. The mojo shell needs to know about the
renderer's URL on ConnectToApplication or else it fails. What I'm doing here is
telling the shell about the renderer, and once the renderer is available, I send
a Chrome IPC message over to tell it how to connect.

https://codereview.chromium.org/1476643002/diff/60001/content/browser/mus_util.h
File content/browser/mus_util.h (right):

https://codereview.chromium.org/1476643002/diff/60001/content/browser/mus_uti...
content/browser/mus_util.h:18: mus::Window* GetMusWindow(aura::Window* window);
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> this utility should probably live in ui/aura/mus, with a corresponding setter
> functino

Done.

https://codereview.chromium.org/1476643002/diff/60001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_mus.cc (right):

https://codereview.chromium.org/1476643002/diff/60001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_mus.cc:112: std::string
url = GetMojoApplicationInstanceURL(host_->GetProcess());
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> just put this in the ctor since no one else calls it.

Done.

https://codereview.chromium.org/1476643002/diff/60001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/1476643002/diff/60001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:10: #include
"base/debug/stack_trace.h"
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> remove

Done.

https://codereview.chromium.org/1476643002/diff/60001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:422: //
base::debug::StackTrace().Print();
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> remove

Done.

https://codereview.chromium.org/1476643002/diff/60001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:540: 
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> undo

Done.

https://codereview.chromium.org/1476643002/diff/60001/content/child/child_thr...
File content/child/child_thread_impl.h (right):

https://codereview.chromium.org/1476643002/diff/60001/content/child/child_thr...
content/child/child_thread_impl.h:196: #if defined(MOJO_SHELL_CLIENT)
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> this is absolutely going to cause you pain, get rid of it.
> 
> Instead, I think we should probably separate creation of the
MojoShellConnection
> from binding it to a pipe. You can add a bare create method and call it early
in
> RendererMain(). That means we can add listeners early.
> 
> Then add two bind methods:
> BindToMessagePipe
> BindToCommandLinePlatformChannel

Done.

https://codereview.chromium.org/1476643002/diff/60001/content/common/render_p...
File content/common/render_process_client.mojom (right):

https://codereview.chromium.org/1476643002/diff/60001/content/common/render_p...
content/common/render_process_client.mojom:9: interface RenderProcessClient {
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> RenderWidgetWindowTreeClientFactory

Done.

https://codereview.chromium.org/1476643002/diff/60001/content/common/render_p...
content/common/render_process_client.mojom:11: mus.mojom.WindowTreeClient&
window_tree_client);
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> CreateWindowTreeClientForRenderWidget(uint32 routing_id, ...)

Done.

https://codereview.chromium.org/1476643002/diff/60001/content/public/browser/...
File content/public/browser/BUILD.gn (right):

https://codereview.chromium.org/1476643002/diff/60001/content/public/browser/...
content/public/browser/BUILD.gn:49: "//content/public/common:mojo_shell_client",
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> what do you need this for?

I don't anymore.

https://codereview.chromium.org/1476643002/diff/60001/content/renderer/render...
File content/renderer/render_process_client_connection_listener.cc (right):

https://codereview.chromium.org/1476643002/diff/60001/content/renderer/render...
content/renderer/render_process_client_connection_listener.cc:22: class
RenderProcessClientConnectionListener
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> RenderWidgetWindowTreeClientFactoryImpl

Done.

https://codereview.chromium.org/1476643002/diff/60001/content/renderer/render...
File content/renderer/render_process_client_connection_listener.h (right):

https://codereview.chromium.org/1476643002/diff/60001/content/renderer/render...
content/renderer/render_process_client_connection_listener.h:10: void
CreateRenderProcessClientConnectionListener();
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> CreateRenderWidgetWindowTreeClientFactory

Done.

https://codereview.chromium.org/1476643002/diff/60001/content/renderer/render...
File content/renderer/render_widget_mus_connection.h (right):

https://codereview.chromium.org/1476643002/diff/60001/content/renderer/render...
content/renderer/render_widget_mus_connection.h:40:
scoped_ptr<mojo::Binding<mus::mojom::WindowTreeClient>> binding_;
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> what is this used for?

Removed.

https://codereview.chromium.org/1476643002/diff/60001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/1476643002/diff/60001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:185: content_->SetNativeWindowProperty("mus",
window_);
On 2015/11/25 04:07:28, Ben Goodger (Google) wrote:
> use the setter you defined in ui/aura/mus

Done.

[Fady Samuel, 2015-11-25 17:47:33]

Description was changed from

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a RenderProcessClient 
interface from the renderer. It uses that client ptr to 
issue an OnRenderWidgetHostViewcreated with the host 
routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderProcessClient and handles it in 
RenderProcessClientConnectionListener. The renderer sees 
the subsequent OnRenderWidgetHostViewCreated call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient 
interface request to establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root and starts putting things 
on screen inside this window.

BUG=551250
==========

to

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a 
RenderWidgetWindowTreeClientFactory interface from the renderer. It 
uses that client ptr to issue an OnRenderWidgetHostViewcreated with the 
host routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderWidgetWindowTreeClientFactory and handles it in 
RenderWidgetWindowTreeClientFactoryImpl. The renderer sees 
the subsequent CreateWindowTreeClientForRenderWidget call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient 
interface request to establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root and starts putting things 
on screen inside this window.

BUG=551250
==========

[Fady Samuel, 2015-11-25 17:50:32]

Description was changed from

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a 
RenderWidgetWindowTreeClientFactory interface from the renderer. It 
uses that client ptr to issue an OnRenderWidgetHostViewcreated with the 
host routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderWidgetWindowTreeClientFactory and handles it in 
RenderWidgetWindowTreeClientFactoryImpl. The renderer sees 
the subsequent CreateWindowTreeClientForRenderWidget call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient 
interface request to establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root and starts putting things 
on screen inside this window.

BUG=551250
==========

to

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a 
RenderWidgetWindowTreeClientFactory interface from the renderer. It 
uses that client ptr to issue an CreateWindowTreeClientForRenderWidget
with the host routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderWidgetWindowTreeClientFactory and handles it in 
RenderWidgetWindowTreeClientFactoryImpl. The renderer sees 
the subsequent CreateWindowTreeClientForRenderWidget call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient 
interface request to establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root and starts putting things 
on screen inside this window.

BUG=551250
==========

[Ben Goodger (Google), 2015-11-25 20:28:15]

https://codereview.chromium.org/1476643002/diff/100001/content/browser/mojo/m...
File content/browser/mojo/mojo_shell_client_host.h (right):

https://codereview.chromium.org/1476643002/diff/100001/content/browser/mojo/m...
content/browser/mojo/mojo_shell_client_host.h:30: void
BindExternalMojoShellHandle(base::ProcessHandle process_handle,
SendExternalShellHandleToChild()

https://codereview.chromium.org/1476643002/diff/100001/content/public/browser...
File content/public/browser/BUILD.gn (right):

https://codereview.chromium.org/1476643002/diff/100001/content/public/browser...
content/public/browser/BUILD.gn:49: "//content/public/common:mojo_shell_client",
???

https://codereview.chromium.org/1476643002/diff/100001/content/renderer/rende...
File content/renderer/render_widget_window_tree_client_factory.cc (right):

https://codereview.chromium.org/1476643002/diff/100001/content/renderer/rende...
content/renderer/render_widget_window_tree_client_factory.cc:27: static void
Create() { new RenderWidgetWindowTreeClientFactoryImpl; }
at this point you may as well just make the ctor public

https://codereview.chromium.org/1476643002/diff/100001/content/renderer/rende...
content/renderer/render_widget_window_tree_client_factory.cc:35:
~RenderWidgetWindowTreeClientFactoryImpl() override {}
how is this object ever deleted?

[Fady Samuel, 2015-11-25 20:46:50]

PTAL Ben! Once you're happy with this I'll pass it to jam@ for OWNER approval.

https://codereview.chromium.org/1476643002/diff/100001/content/browser/mojo/m...
File content/browser/mojo/mojo_shell_client_host.h (right):

https://codereview.chromium.org/1476643002/diff/100001/content/browser/mojo/m...
content/browser/mojo/mojo_shell_client_host.h:30: void
BindExternalMojoShellHandle(base::ProcessHandle process_handle,
On 2015/11/25 20:28:14, Ben Goodger (Google) wrote:
> SendExternalShellHandleToChild()

Done.

https://codereview.chromium.org/1476643002/diff/100001/content/public/browser...
File content/public/browser/BUILD.gn (right):

https://codereview.chromium.org/1476643002/diff/100001/content/public/browser...
content/public/browser/BUILD.gn:49: "//content/public/common:mojo_shell_client",
On 2015/11/25 20:28:15, Ben Goodger (Google) wrote:
> ???

Argh, I thought I reverted that, not sure how it got back here.

https://codereview.chromium.org/1476643002/diff/100001/content/renderer/rende...
File content/renderer/render_widget_window_tree_client_factory.cc (right):

https://codereview.chromium.org/1476643002/diff/100001/content/renderer/rende...
content/renderer/render_widget_window_tree_client_factory.cc:27: static void
Create() { new RenderWidgetWindowTreeClientFactoryImpl; }
On 2015/11/25 20:28:15, Ben Goodger (Google) wrote:
> at this point you may as well just make the ctor public

Done.

https://codereview.chromium.org/1476643002/diff/100001/content/renderer/rende...
content/renderer/render_widget_window_tree_client_factory.cc:35:
~RenderWidgetWindowTreeClientFactoryImpl() override {}
On 2015/11/25 20:28:15, Ben Goodger (Google) wrote:
> how is this object ever deleted?

It's owned by MojoShellConnection because it's a listener.

[Ben Goodger (Google), 2015-11-25 20:50:56]

lgtm

https://codereview.chromium.org/1476643002/diff/100001/content/renderer/rende...
File content/renderer/render_widget_window_tree_client_factory.cc (right):

https://codereview.chromium.org/1476643002/diff/100001/content/renderer/rende...
content/renderer/render_widget_window_tree_client_factory.cc:35:
~RenderWidgetWindowTreeClientFactoryImpl() override {}
On 2015/11/25 20:46:50, Fady Samuel wrote:
> On 2015/11/25 20:28:15, Ben Goodger (Google) wrote:
> > how is this object ever deleted?
> 
> It's owned by MojoShellConnection because it's a listener.

duh. i know you have the comment in MojoShellConnection, but can you add another
note here or at the top of the class confirming that.

[Fady Samuel, 2015-11-25 20:56:13]

On 2015/11/25 20:50:56, Ben Goodger (Google) wrote:
> lgtm
> 
>
https://codereview.chromium.org/1476643002/diff/100001/content/renderer/rende...
> File content/renderer/render_widget_window_tree_client_factory.cc (right):
> 
>
https://codereview.chromium.org/1476643002/diff/100001/content/renderer/rende...
> content/renderer/render_widget_window_tree_client_factory.cc:35:
> ~RenderWidgetWindowTreeClientFactoryImpl() override {}
> On 2015/11/25 20:46:50, Fady Samuel wrote:
> > On 2015/11/25 20:28:15, Ben Goodger (Google) wrote:
> > > how is this object ever deleted?
> > 
> > It's owned by MojoShellConnection because it's a listener.
> 
> duh. i know you have the comment in MojoShellConnection, but can you add
another
> note here or at the top of the class confirming that.

Done. Passing this to John now.

[Fady Samuel, 2015-11-25 20:56:38]

fsamuel@chromium.org changed reviewers:
+ jam@chromium.org

[Fady Samuel, 2015-11-25 20:56:38]

Hi John! The Chrome renderer can now talk to Mus! w00t! Please review!

[jam, 2015-11-25 21:26:15]

lgtm with comment

https://codereview.chromium.org/1476643002/diff/50031/content/public/common/m...
File content/public/common/mojo_shell_connection.h (right):

https://codereview.chromium.org/1476643002/diff/50031/content/public/common/m...
content/public/common/mojo_shell_connection.h:48: virtual void
BindToCommandLinePlatformChannel() = 0;
these are only used by internal content code, so they shouldn't be on the public
interface. instead they should be on MojoShellCOnnectionImpl. the code calling
it can either static cast to the impl, or MojoShellCOnnectionImpl can have a
Get() method

i didn't check, but are any of the methods here also only called from inside
content? if so they should all be internal

[Fady Samuel, 2015-11-25 22:04:45]

fsamuel@chromium.org changed reviewers:
+ palmer@chromium.org

[Fady Samuel, 2015-11-25 22:04:46]

+palmer@ for mojom review.

[Fady Samuel, 2015-11-25 23:13:50]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 23:15:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476643002/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476643002/170001

[palmer, 2015-11-25 23:48:00]

LGTM. 1 note about that static_cast, though.

https://codereview.chromium.org/1476643002/diff/170001/content/browser/mojo/m...
File content/browser/mojo/mojo_shell_client_host.cc (right):

https://codereview.chromium.org/1476643002/diff/170001/content/browser/mojo/m...
content/browser/mojo/mojo_shell_client_host.cc:128: InstanceShellHandle*
client_file = static_cast<InstanceShellHandle*>(
We are certain this cast is safe, because only trustworthy code put a
trustowrthy value for kMojoPlatformFile in, right?

[Fady Samuel, 2015-11-25 23:57:24]

CQ'ing now.

https://codereview.chromium.org/1476643002/diff/170001/content/browser/mojo/m...
File content/browser/mojo/mojo_shell_client_host.cc (right):

https://codereview.chromium.org/1476643002/diff/170001/content/browser/mojo/m...
content/browser/mojo/mojo_shell_client_host.cc:128: InstanceShellHandle*
client_file = static_cast<InstanceShellHandle*>(
On 2015/11/25 23:48:00, palmer wrote:
> We are certain this cast is safe, because only trustworthy code put a
> trustowrthy value for kMojoPlatformFile in, right?

Yes, we trust the mojo shell just as we trust the browser process so we trust
this value.

[commit-bot: I haz the power, 2015-11-26 00:25:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 00:25:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2015-11-26 00:55:04]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-11-26 00:55:04]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org,
jam@chromium.org, palmer@chromium.org
Link to the patchset: https://codereview.chromium.org/1476643002/#ps190001
(title: "Added missing include guard")

[commit-bot: I haz the power, 2015-11-26 00:57:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476643002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476643002/190001

[jam, 2015-11-26 01:03:36]

The CQ bit was unchecked by jam@chromium.org

[jam, 2015-11-26 01:04:22]

The CQ bit was checked by jam@chromium.org

[jam, 2015-11-26 01:04:30]

https://codereview.chromium.org/1476643002/diff/190001/content/public/common/...
File content/public/common/mojo_shell_connection.h (right):

https://codereview.chromium.org/1476643002/diff/190001/content/public/common/...
content/public/common/mojo_shell_connection.h:9: #include
"mojo/public/cpp/system/message_pipe.h"
no need for this anymore.

[commit-bot: I haz the power, 2015-11-26 01:08:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476643002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476643002/190001

[Fady Samuel, 2015-11-26 01:13:54]

CQ'ing.

https://codereview.chromium.org/1476643002/diff/190001/content/public/common/...
File content/public/common/mojo_shell_connection.h (right):

https://codereview.chromium.org/1476643002/diff/190001/content/public/common/...
content/public/common/mojo_shell_connection.h:9: #include
"mojo/public/cpp/system/message_pipe.h"
On 2015/11/26 01:04:30, jam wrote:
> no need for this anymore.

Done.

[Fady Samuel, 2015-11-26 01:14:02]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-11-26 01:14:03]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
jam@chromium.org, ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1476643002/#ps210001
(title: "Remove unnecessary include")

[commit-bot: I haz the power, 2015-11-26 01:15:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476643002/210001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476643002/210001

[commit-bot: I haz the power, 2015-11-26 02:18:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 02:18:14]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2015-11-26 02:24:20]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-11-26 02:24:21]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
jam@chromium.org, ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1476643002/#ps230001
(title: "Don't create a RenderWidgetWindowTreeeClientFactory in tests")

[commit-bot: I haz the power, 2015-11-26 02:25:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476643002/230001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476643002/230001

[commit-bot: I haz the power, 2015-11-26 04:27:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 04:27:38]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[Fady Samuel, 2015-11-26 04:28:18]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2015-11-26 04:29:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476643002/230001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476643002/230001

[commit-bot: I haz the power, 2015-11-26 05:13:52]

Description was changed from

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a 
RenderWidgetWindowTreeClientFactory interface from the renderer. It 
uses that client ptr to issue an CreateWindowTreeClientForRenderWidget
with the host routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderWidgetWindowTreeClientFactory and handles it in 
RenderWidgetWindowTreeClientFactoryImpl. The renderer sees 
the subsequent CreateWindowTreeClientForRenderWidget call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient 
interface request to establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root and starts putting things 
on screen inside this window.

BUG=551250
==========

to

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a 
RenderWidgetWindowTreeClientFactory interface from the renderer. It 
uses that client ptr to issue an CreateWindowTreeClientForRenderWidget
with the host routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderWidgetWindowTreeClientFactory and handles it in 
RenderWidgetWindowTreeClientFactoryImpl. The renderer sees 
the subsequent CreateWindowTreeClientForRenderWidget call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient 
interface request to establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root and starts putting things 
on screen inside this window.

BUG=551250
==========

[commit-bot: I haz the power, 2015-11-26 05:13:53]

Committed patchset #13 (id:230001)

[commit-bot: I haz the power, 2015-11-26 05:14:32]

Description was changed from

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable 
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a 
RenderWidgetWindowTreeClientFactory interface from the renderer. It 
uses that client ptr to issue an CreateWindowTreeClientForRenderWidget
with the host routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for 
RenderWidgetWindowTreeClientFactory and handles it in 
RenderWidgetWindowTreeClientFactoryImpl. The renderer sees 
the subsequent CreateWindowTreeClientForRenderWidget call, and 
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient 
interface request to establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus 
with a mus::Window as its root and starts putting things 
on screen inside this window.

BUG=551250
==========

to

==========
mustash: Enable connections to mus from the Chrome renderer [take 2]

This CL introduces the initial plumbing to enable
connections to mus from the Chrome renderer.

The connection is established as follows:

1. RenderWidgetHostViewMus requests a
RenderWidgetWindowTreeClientFactory interface from the renderer. It
uses that client ptr to issue an CreateWindowTreeClientForRenderWidget
with the host routing ID and an interface request to a WindowTreeClient.

2. The renderer receives the request for
RenderWidgetWindowTreeClientFactory and handles it in
RenderWidgetWindowTreeClientFactoryImpl. The renderer sees
the subsequent CreateWindowTreeClientForRenderWidget call, and
creates a RenderWidgetMusConnection.

3. RenderWidgetMusConnection uses the WindowTreeClient
interface request to establish a WindowTreeConnection.

4. RenderWidgetMusConnection receives an OnEmbed from mus
with a mus::Window as its root and starts putting things
on screen inside this window.

BUG=551250

Committed: https://crrev.com/6c6da0233c011d29cc7c43221fb8f5482405dfb6
Cr-Commit-Position: refs/heads/master@{#361820}
==========

[commit-bot: I haz the power, 2015-11-26 05:14:33]

Patchset 13 (id:??) landed as
https://crrev.com/6c6da0233c011d29cc7c43221fb8f5482405dfb6
Cr-Commit-Position: refs/heads/master@{#361820}

[jochen (gone - plz use gerrit), 2015-12-01 10:33:12]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-12-01 10:33:13]

https://codereview.chromium.org/1476643002/diff/230001/content/common/render_...
File content/common/render_widget_window_tree_client_factory.mojom (right):

https://codereview.chromium.org/1476643002/diff/230001/content/common/render_...
content/common/render_widget_window_tree_client_factory.mojom:7: import
"components/mus/public/interfaces/window_tree.mojom";
hum, the gn target of this file does not depend on the mus/public/interfaces,
nor on ui/mojo/imi (which the public interfaces depend on)