mustash: Enable connections to mus from the Chrome renderer [take 2]

content/child/child_thread_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_CHILD_CHILD_THREAD_IMPL_H_
 #define CONTENT_CHILD_CHILD_THREAD_IMPL_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 175 matching lines @@
   }
 
  protected:
   friend class ChildProcess;
 
   // Called when the process refcount is 0.
   void OnProcessFinalRelease();
 
   virtual bool OnControlMessageReceived(const IPC::Message& msg);
   virtual void OnProcessBackgrounded(bool backgrounded);
+#if defined(MOJO_SHELL_CLIENT)

[Ben Goodger (Google), 2015/11/25 04:07:28]

this is absolutely going to cause you pain, get rid of it.

Instead, I think we should probably separate creation of the MojoShellConnection
from binding it to a pipe. You can add a bare create method and call it early in
RendererMain(). That means we can add listeners early.

Then add two bind methods:
BindToMessagePipe
BindToCommandLinePlatformChannel

[Fady Samuel, 2015/11/25 17:45:52]

Done.

+  virtual void OnMojoReady() {}
+#endif
 
   void set_on_channel_error_called(bool on_channel_error_called) {
     on_channel_error_called_ = on_channel_error_called;
   }
 
   // IPC::Listener implementation:
   bool OnMessageReceived(const IPC::Message& msg) override;
   void OnChannelConnected(int32 peer_pid) override;
   void OnChannelError() override;
 
@@ skipping 128 matching lines @@
 
  private:
   struct Options options_;
 
   DISALLOW_COPY_AND_ASSIGN(Builder);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_CHILD_CHILD_THREAD_IMPL_H_