mustash: Enable connections to mus from the Chrome renderer [take 2]

content/public/common/mojo_shell_connection.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_MOJO_SHELL_CONNECTION_H_
 #define CONTENT_PUBLIC_COMMON_MOJO_SHELL_CONNECTION_H_
 
 #include "content/common/content_export.h"
+#include "mojo/public/cpp/system/message_pipe.h"
 
 namespace mojo {
 class ApplicationConnection;
 class ApplicationImpl;
 }
 
 namespace content {
 
 // Encapsulates a connection to a spawning external Mojo shell.
 // Access an instance by calling Get(), on the thread the Shell connection is
 // bound. Clients can implement Listener, which allows them to register services
 // to expose to inbound connections. Clients should call this any time after
 // the main message loop is created but not yet run (e.g. in the browser process
 // this object is created in PreMainMessageLoopRun(), so the BrowserMainParts
 // impl can access this in its implementation of that same method.
 class CONTENT_EXPORT MojoShellConnection {
  public:
   // Override to add additional services to inbound connections.
   class Listener {
    public:
     virtual bool ConfigureIncomingConnection(
         mojo::ApplicationConnection* connection) = 0;
 
-   protected:
     virtual ~Listener() {}
   };
 
   // Will return null if no connection has been established (either because it
   // hasn't happened yet or the application was not spawned from the external
   // Mojo shell.
   static MojoShellConnection* Get();
 
   // Destroys the connection. Must be called on the thread the connection was
   // created on.
   static void Destroy();
 
+  // Blocks the calling thread until calling GetApplication() will return an
+  // Initialized() application with a bound ShellPtr. This call is a no-op
+  // if the connection has already been initialized.
+  virtual void BindToCommandLinePlatformChannel() = 0;

[jam, 2015/11/25 21:26:15]

these are only used by internal content code, so they shouldn't be on the public
interface. instead they should be on MojoShellCOnnectionImpl. the code calling
it can either static cast to the impl, or MojoShellCOnnectionImpl can have a
Get() method

i didn't check, but are any of the methods here also only called from inside
content? if so they should all be internal

+
+  // Same as BindToCommandLinePlatformChannel(), but receives a handle instead
+  // of looking for one on the command line.
+  virtual void BindToMessagePipe(mojo::ScopedMessagePipeHandle handle) = 0;
+
   // Returns an Initialized() ApplicationImpl.
   virtual mojo::ApplicationImpl* GetApplication() = 0;
 
   // [De]Register an impl of Listener that will be consulted when the wrapped
   // ApplicationImpl exposes services to inbound connections.
+  // Registered listeners are owned by this MojoShellConnection.
   virtual void AddListener(Listener* listener) = 0;
   virtual void RemoveListener(Listener* listener) = 0;
 
  protected:
   virtual ~MojoShellConnection();
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_MOJO_SHELL_CONNECTION_H_