content/public/common/mojo_shell_connection.h - Issue 1476643002: mustash: Enable connections to mus from the Chrome renderer [take 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/mojo_shell_connection.h

Issue 1476643002: mustash: Enable connections to mus from the Chrome renderer [take 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't create a RenderWidgetWindowTreeeClientFactory in tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/render_widget_window_tree_client_factory.mojom ('K') | « content/common/render_widget_window_tree_client_factory.mojom ('k') | content/renderer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/mojo_shell_connection.h

diff --git a/content/public/common/mojo_shell_connection.h b/content/public/common/mojo_shell_connection.h

index af4cce1341484871827a2450e83114662ce8155e..e42e3c085124ebe7d0a3df2d1f063f6ebe2fb3ec 100644

--- a/content/public/common/mojo_shell_connection.h

+++ b/content/public/common/mojo_shell_connection.h

@@ -29,7 +29,6 @@ class CONTENT_EXPORT MojoShellConnection {

virtual bool ConfigureIncomingConnection(

mojo::ApplicationConnection* connection) = 0;

- protected:

virtual ~Listener() {}

};

@@ -47,6 +46,7 @@ class CONTENT_EXPORT MojoShellConnection {

// [De]Register an impl of Listener that will be consulted when the wrapped

// ApplicationImpl exposes services to inbound connections.

+ // Registered listeners are owned by this MojoShellConnection.

virtual void AddListener(Listener* listener) = 0;

virtual void RemoveListener(Listener* listener) = 0;