Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1474963002: [turbofan] Implemented the optional Float32RoundUp operator. (Closed)

Created:
5 years ago by ahaas
Modified:
5 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@f32rounddown
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Implemented the optional Float32RoundUp operator. The Float32RoundUp operator rounds float32 numbers towards infinity. The operator is currently implemented on x64, ia32, arm, and arm64. R=titzer@chromium.org Committed: https://crrev.com/4f4947898d3a5c23b5545aed195e97295a64e18b Cr-Commit-Position: refs/heads/master@{#32262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -28 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +17 lines, -15 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1471913006 Patch 1

Dependent Patchsets:

Issue 1468303005 Patch 1

Messages

Total messages: 6 (1 generated)
ahaas
5 years ago (2015-11-25 08:42:03 UTC) #1
titzer
lgtm
5 years ago (2015-11-25 09:45:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474963002/1
5 years ago (2015-11-25 11:06:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 11:07:54 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-25 11:08:27 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4f4947898d3a5c23b5545aed195e97295a64e18b
Cr-Commit-Position: refs/heads/master@{#32262}

Powered by Google App Engine
This is Rietveld 408576698