Delete Assembler::FlushICacheWithoutIsolate

Delete Assembler::FlushICacheWithoutIsolate

Requires passing an explicit Isolate* to a bunch of static Assembler
methods.

BUG=v8:2487
R=yangguo@chromium.org,jkummerow@chromium.org
LOG=n

Committed: https://crrev.com/c08e952566c3923f8fcbd693dae05f8eae73938b
Cr-Commit-Position: refs/heads/master@{#32376}

[jochen (gone - plz use gerrit), 2015-11-27 12:23:08]

ptal

Yang, overall
Jakob, full-codegen + ic

[Yang, 2015-11-27 12:30:34]

lgtm

[Jakob Kummerow, 2015-11-27 12:51:53]

ic and full-codegen LGTM.

https://codereview.chromium.org/1474323002/diff/20001/src/full-codegen/arm/fu...
File src/full-codegen/arm/full-codegen-arm.cc (right):

https://codereview.chromium.org/1474323002/diff/20001/src/full-codegen/arm/fu...
src/full-codegen/arm/full-codegen-arm.cc:4980:
Assembler::set_target_address_at(unoptimized_code->GetIsolate(),
I'm not overly fond of calling ->GetIsolate() twice in the same function (the
CodePatcher already needs it in line 4928), but the cost of that is probably
dwarfed by the cost of patching code in the first place.

(This comment applies to all non-Intel platforms.)

[jochen (gone - plz use gerrit), 2015-11-27 12:59:08]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-11-27 12:59:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
yangguo@chromium.org, jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1474323002/#ps40001
(title: "updates")

[jochen (gone - plz use gerrit), 2015-11-27 12:59:20]

consolidated the GetIsolate() calls where it made sense

[commit-bot: I haz the power, 2015-11-27 12:59:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474323002/40001

[commit-bot: I haz the power, 2015-11-27 13:35:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-27 13:35:55]

Description was changed from

==========
Delete Assembler::FlushICacheWithoutIsolate

Requires passing an explicit Isolate* to a bunch of static Assembler
methods.

BUG=v8:2487
R=yangguo@chromium.org,jkummerow@chromium.org
LOG=n
==========

to

==========
Delete Assembler::FlushICacheWithoutIsolate

Requires passing an explicit Isolate* to a bunch of static Assembler
methods.

BUG=v8:2487
R=yangguo@chromium.org,jkummerow@chromium.org
LOG=n

Committed: https://crrev.com/c08e952566c3923f8fcbd693dae05f8eae73938b
Cr-Commit-Position: refs/heads/master@{#32376}
==========

[commit-bot: I haz the power, 2015-11-27 13:35:56]

Patchset 3 (id:??) landed as
https://crrev.com/c08e952566c3923f8fcbd693dae05f8eae73938b
Cr-Commit-Position: refs/heads/master@{#32376}