src/full-codegen/ia32/full-codegen-ia32.cc - Issue 1474323002: Delete Assembler::FlushICacheWithoutIsolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1474323002: Delete Assembler::FlushICacheWithoutIsolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 3a3e649cda7e786953b8d345a02ab06398e5aa38..a4ac02e4870436216cafadfd8a8ae70e0df655bf 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -4836,8 +4836,8 @@ void BackEdgeTable::PatchAt(Code* unoptimized_code,

break;

}

- Assembler::set_target_address_at(call_target_address,

- unoptimized_code,

+ Assembler::set_target_address_at(unoptimized_code->GetIsolate(),

+ call_target_address, unoptimized_code,

replacement_code->entry());

unoptimized_code->GetHeap()->incremental_marking()->RecordCodeTargetPatch(

unoptimized_code, call_target_address, replacement_code);