| Index: src/arm/assembler-arm-inl.h
|
| diff --git a/src/arm/assembler-arm-inl.h b/src/arm/assembler-arm-inl.h
|
| index 175a21df51b2d52bb82f24bf0284805f4c37b438..c9602ea028f4f5c61e90cdb6e46bf423783a8c6d 100644
|
| --- a/src/arm/assembler-arm-inl.h
|
| +++ b/src/arm/assembler-arm-inl.h
|
| @@ -104,7 +104,8 @@ void RelocInfo::set_target_address(Address target,
|
| WriteBarrierMode write_barrier_mode,
|
| ICacheFlushMode icache_flush_mode) {
|
| DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_));
|
| - Assembler::set_target_address_at(pc_, host_, target, icache_flush_mode);
|
| + Assembler::set_target_address_at(isolate_, pc_, host_, target,
|
| + icache_flush_mode);
|
| if (write_barrier_mode == UPDATE_WRITE_BARRIER &&
|
| host() != NULL && IsCodeTarget(rmode_)) {
|
| Object* target_code = Code::GetCodeFromTargetAddress(target);
|
| @@ -131,7 +132,7 @@ void RelocInfo::set_target_object(Object* target,
|
| WriteBarrierMode write_barrier_mode,
|
| ICacheFlushMode icache_flush_mode) {
|
| DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
|
| - Assembler::set_target_address_at(pc_, host_,
|
| + Assembler::set_target_address_at(isolate_, pc_, host_,
|
| reinterpret_cast<Address>(target),
|
| icache_flush_mode);
|
| if (write_barrier_mode == UPDATE_WRITE_BARRIER &&
|
| @@ -257,7 +258,7 @@ void RelocInfo::WipeOut() {
|
| if (IsInternalReference(rmode_)) {
|
| Memory::Address_at(pc_) = NULL;
|
| } else {
|
| - Assembler::set_target_address_at(pc_, host_, NULL);
|
| + Assembler::set_target_address_at(isolate_, pc_, host_, NULL);
|
| }
|
| }
|
|
|
| @@ -472,9 +473,9 @@ Address Assembler::return_address_from_call_start(Address pc) {
|
|
|
|
|
| void Assembler::deserialization_set_special_target_at(
|
| - Address constant_pool_entry, Code* code, Address target) {
|
| + Isolate* isolate, Address constant_pool_entry, Code* code, Address target) {
|
| if (FLAG_enable_embedded_constant_pool) {
|
| - set_target_address_at(constant_pool_entry, code, target);
|
| + set_target_address_at(isolate, constant_pool_entry, code, target);
|
| } else {
|
| Memory::Address_at(constant_pool_entry) = target;
|
| }
|
| @@ -482,7 +483,7 @@ void Assembler::deserialization_set_special_target_at(
|
|
|
|
|
| void Assembler::deserialization_set_target_internal_reference_at(
|
| - Address pc, Address target, RelocInfo::Mode mode) {
|
| + Isolate* isolate, Address pc, Address target, RelocInfo::Mode mode) {
|
| Memory::Address_at(pc) = target;
|
| }
|
|
|
| @@ -572,15 +573,15 @@ Address Assembler::target_address_at(Address pc, Address constant_pool) {
|
| }
|
|
|
|
|
| -void Assembler::set_target_address_at(Address pc, Address constant_pool,
|
| - Address target,
|
| +void Assembler::set_target_address_at(Isolate* isolate, Address pc,
|
| + Address constant_pool, Address target,
|
| ICacheFlushMode icache_flush_mode) {
|
| if (is_constant_pool_load(pc)) {
|
| // This is a constant pool lookup. Update the entry in the constant pool.
|
| Memory::Address_at(constant_pool_entry_address(pc, constant_pool)) = target;
|
| // Intuitively, we would think it is necessary to always flush the
|
| // instruction cache after patching a target address in the code as follows:
|
| - // Assembler::FlushICacheWithoutIsolate(pc, sizeof(target));
|
| + // Assembler::FlushICache(isolate, pc, sizeof(target));
|
| // However, on ARM, no instruction is actually patched in the case
|
| // of embedded constants of the form:
|
| // ldr ip, [pp, #...]
|
| @@ -598,7 +599,7 @@ void Assembler::set_target_address_at(Address pc, Address constant_pool,
|
| DCHECK(IsMovW(Memory::int32_at(pc)));
|
| DCHECK(IsMovT(Memory::int32_at(pc + kInstrSize)));
|
| if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
|
| - Assembler::FlushICacheWithoutIsolate(pc, 2 * kInstrSize);
|
| + Assembler::FlushICache(isolate, pc, 2 * kInstrSize);
|
| }
|
| } else {
|
| // This is an mov / orr immediate load. Patch the immediate embedded in
|
| @@ -618,7 +619,7 @@ void Assembler::set_target_address_at(Address pc, Address constant_pool,
|
| IsOrrImmed(Memory::int32_at(pc + 2 * kInstrSize)) &&
|
| IsOrrImmed(Memory::int32_at(pc + 3 * kInstrSize)));
|
| if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
|
| - Assembler::FlushICacheWithoutIsolate(pc, 4 * kInstrSize);
|
| + Assembler::FlushICache(isolate, pc, 4 * kInstrSize);
|
| }
|
| }
|
| }
|
|
|