Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/assembler.cc

Issue 1474323002: Delete Assembler::FlushICacheWithoutIsolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/assembler.h ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 if (CpuFeatures::IsSupported(COHERENT_CACHE)) return; 198 if (CpuFeatures::IsSupported(COHERENT_CACHE)) return;
199 199
200 #if defined(USE_SIMULATOR) 200 #if defined(USE_SIMULATOR)
201 Simulator::FlushICache(isolate->simulator_i_cache(), start, size); 201 Simulator::FlushICache(isolate->simulator_i_cache(), start, size);
202 #else 202 #else
203 CpuFeatures::FlushICache(start, size); 203 CpuFeatures::FlushICache(start, size);
204 #endif // USE_SIMULATOR 204 #endif // USE_SIMULATOR
205 } 205 }
206 206
207 207
208 void AssemblerBase::FlushICacheWithoutIsolate(void* start, size_t size) {
209 // Ideally we would just call Isolate::Current() here. However, this flushes
210 // out issues because we usually only need the isolate when in the simulator.
211 Isolate* isolate;
212 #if defined(USE_SIMULATOR)
213 isolate = Isolate::Current();
214 #else
215 isolate = nullptr;
216 #endif // USE_SIMULATOR
217 FlushICache(isolate, start, size);
218 }
219
220
221 void AssemblerBase::Print() { 208 void AssemblerBase::Print() {
222 OFStream os(stdout); 209 OFStream os(stdout);
223 v8::internal::Disassembler::Decode(isolate(), &os, buffer_, pc_, nullptr); 210 v8::internal::Disassembler::Decode(isolate(), &os, buffer_, pc_, nullptr);
224 } 211 }
225 212
226 213
227 // ----------------------------------------------------------------------------- 214 // -----------------------------------------------------------------------------
228 // Implementation of PredictableCodeSizeScope 215 // Implementation of PredictableCodeSizeScope
229 216
230 PredictableCodeSizeScope::PredictableCodeSizeScope(AssemblerBase* assembler) 217 PredictableCodeSizeScope::PredictableCodeSizeScope(AssemblerBase* assembler)
(...skipping 1677 matching lines...) Expand 10 before | Expand all | Expand 10 after
1908 1895
1909 1896
1910 void Assembler::DataAlign(int m) { 1897 void Assembler::DataAlign(int m) {
1911 DCHECK(m >= 2 && base::bits::IsPowerOfTwo32(m)); 1898 DCHECK(m >= 2 && base::bits::IsPowerOfTwo32(m));
1912 while ((pc_offset() & (m - 1)) != 0) { 1899 while ((pc_offset() & (m - 1)) != 0) {
1913 db(0); 1900 db(0);
1914 } 1901 }
1915 } 1902 }
1916 } // namespace internal 1903 } // namespace internal
1917 } // namespace v8 1904 } // namespace v8
OLDNEW
« no previous file with comments | « src/assembler.h ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698