Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 147203004: aura: Remove event-dispatch methods from WindowTreeHostDelegate interface. (Closed)

Created:
6 years, 10 months ago by sadrul
Modified:
6 years, 10 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, viettrungluu+watch_chromium.org, dcheng, yukishiino+watch_chromium.org, ben+aura_chromium.org, ben+mojo_chromium.org, yusukes+watch_chromium.org, stevenjb+watch_chromium.org, jam, abarth-chromium, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, oshima+watch_chromium.org, ben+corewm_chromium.org, ben+views_chromium.org, jochen+watch_chromium.org, tfarina, Aaron Boodman, ben+ash_chromium.org, darin (slow to review), James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

aura: Remove event-dispatch methods from WindowTreeHostDelegate interface. Update the aura::WindowTreeHost implementations to also be ui::EventSource, and remove the event-dispatch related methods from the WindowTreeHostDelegate interface. The implementation of the WindowTreeHostDelegate interface related to event-dispatch in RootWindow uses ui::EventProcessor for dispatching events anyway, and so it is a good time to remove this redundant code. BUG=318879 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248154

Patch Set 1 #

Patch Set 2 : fix-mojo #

Patch Set 3 : fixes #

Patch Set 4 : fixes #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+608 lines, -571 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M ash/autoclick/autoclick_controller.cc View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M ash/sticky_keys/sticky_keys_controller.cc View 1 2 3 3 chunks +14 lines, -8 lines 0 comments Download
M ash/sticky_keys/sticky_keys_overlay_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ash/sticky_keys/sticky_keys_unittest.cc View 1 2 3 7 chunks +25 lines, -19 lines 0 comments Download
M ash/wm/caption_buttons/frame_maximize_button_unittest.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 2 3 15 chunks +50 lines, -25 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc View 1 2 3 2 chunks +10 lines, -16 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_aura.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_aura.cc View 1 2 3 4 chunks +17 lines, -12 lines 0 comments Download
M content/browser/web_contents/aura/window_slider_unittest.cc View 1 2 3 1 chunk +2 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 2 3 4 chunks +10 lines, -5 lines 0 comments Download
M content/shell/browser/shell_platform_data_aura.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M mojo/examples/aura_demo/root_window_host_mojo.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M mojo/examples/aura_demo/root_window_host_mojo.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
M mojo/examples/launcher/launcher.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 2 3 140 chunks +197 lines, -199 lines 0 comments Download
M ui/aura/remote_root_window_host_win.h View 1 2 3 4 3 chunks +5 lines, -0 lines 0 comments Download
M ui/aura/remote_root_window_host_win.cc View 1 2 3 4 8 chunks +12 lines, -8 lines 0 comments Download
M ui/aura/root_window.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 3 2 chunks +3 lines, -29 lines 0 comments Download
M ui/aura/root_window_host_ozone.cc View 1 chunk +1 line, -10 lines 0 comments Download
M ui/aura/root_window_host_win.h View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download
M ui/aura/root_window_host_win.cc View 1 2 3 4 3 chunks +10 lines, -3 lines 0 comments Download
M ui/aura/root_window_host_x11.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ui/aura/root_window_host_x11_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 1 2 3 28 chunks +48 lines, -68 lines 0 comments Download
M ui/aura/test/aura_test_base.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M ui/aura/test/event_generator.cc View 1 2 3 1 chunk +3 lines, -17 lines 0 comments Download
M ui/aura/window_targeter_unittest.cc View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M ui/aura/window_tree_host_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 2 3 15 chunks +16 lines, -16 lines 0 comments Download
M ui/events/event_source.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/events/event_source.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 2 3 3 chunks +14 lines, -6 lines 0 comments Download
M ui/views/corewm/capture_controller_unittest.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/corewm/compound_event_filter_unittest.cc View 1 2 3 3 chunks +12 lines, -12 lines 0 comments Download
M ui/views/corewm/input_method_event_filter.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 2 3 4 5 6 5 chunks +16 lines, -6 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 5 chunks +14 lines, -7 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 2 3 4 5 2 chunks +5 lines, -3 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 3 4 chunks +22 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
6 years, 10 months ago (2014-01-30 23:51:53 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 10 months ago (2014-01-31 00:07:28 UTC) #2
sadrul
6 years, 10 months ago (2014-01-31 08:24:59 UTC) #3
Message was sent while issue was closed. 
Committed patchset #7 manually as r248154 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698