content/browser/web_contents/aura/window_slider_unittest.cc - Issue 147203004: aura: Remove event-dispatch methods from WindowTreeHostDelegate interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/aura/window_slider_unittest.cc

Issue 147203004: aura: Remove event-dispatch methods from WindowTreeHostDelegate interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: win Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/synthetic_gesture_target_aura.cc ('k') | content/browser/web_contents/web_contents_view_aura_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/aura/window_slider_unittest.cc

diff --git a/content/browser/web_contents/aura/window_slider_unittest.cc b/content/browser/web_contents/aura/window_slider_unittest.cc

index 8e07ee4f248f6c7d752a5cc7fa60a09ea833ae3e..47887bd75dff8220b95ed84a46e727458f2649d2 100644

--- a/content/browser/web_contents/aura/window_slider_unittest.cc

+++ b/content/browser/web_contents/aura/window_slider_unittest.cc

@@ -21,12 +21,8 @@ void DispatchEventDuringScrollCallback(aura::WindowEventDispatcher* dispatcher,

const gfx::Vector2dF& delta) {

if (type != ui::ET_GESTURE_SCROLL_UPDATE)

return;

- aura::WindowTreeHostDelegate* delegate =

- dispatcher->AsWindowTreeHostDelegate();

- if (event->IsMouseEvent())

- delegate->OnHostMouseEvent(static_cast<ui::MouseEvent*>(event));

- else if (event->IsKeyEvent())

- delegate->OnHostKeyEvent(static_cast<ui::KeyEvent*>(event));

+ ui::EventDispatchDetails details = dispatcher->OnEventFromSource(event);

+ CHECK(!details.dispatcher_destroyed);

}

void ChangeSliderOwnerDuringScrollCallback(scoped_ptr<aura::Window>* window,