Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14699002: Move BrowserAction references from ExtensionPrefs to ExtensionActionAPI (Closed)

Created:
7 years, 7 months ago by Devlin
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, tfarina, sail+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move BrowserAction references from ExtensionPrefs to ExtensionActionAPI BUG=180083 TBR=ben@chromium.org, thakis@chromium.org, dbeam@chromium.org ben - gypi, ui/views/, chrome_notification_types thakis - ui/cocoa/ dbeam - ui/webui/ (All just refactoring changes.) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199151

Patch Set 1 : #

Total comments: 2

Patch Set 2 : extension_action_api_unittest -> extension_action_prefs_unittest #

Patch Set 3 : Android fix #

Patch Set 4 : Latest Master for CQ #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -107 lines) Patch
M base/values.cc View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 2 3 2 chunks +33 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/extension_action/extension_action_prefs_unittest.cc View 1 1 chunk +59 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 1 2 3 4 5 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 2 3 4 5 2 chunks +0 lines, -29 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 2 3 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 2 3 4 5 4 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container_browsertest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 1 2 3 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Devlin
7 years, 7 months ago (2013-05-01 00:27:34 UTC) #1
Yoyo Zhou
LGTM https://codereview.chromium.org/14699002/diff/5001/chrome/browser/extensions/api/extension_action/extension_action_api_unittest.cc File chrome/browser/extensions/api/extension_action/extension_action_api_unittest.cc (right): https://codereview.chromium.org/14699002/diff/5001/chrome/browser/extensions/api/extension_action/extension_action_api_unittest.cc#newcode1 chrome/browser/extensions/api/extension_action/extension_action_api_unittest.cc:1: // Copyright (c) 2013 The Chromium Authors. All ...
7 years, 7 months ago (2013-05-02 22:50:07 UTC) #2
Devlin
https://codereview.chromium.org/14699002/diff/5001/chrome/browser/extensions/api/extension_action/extension_action_api_unittest.cc File chrome/browser/extensions/api/extension_action/extension_action_api_unittest.cc (right): https://codereview.chromium.org/14699002/diff/5001/chrome/browser/extensions/api/extension_action/extension_action_api_unittest.cc#newcode1 chrome/browser/extensions/api/extension_action/extension_action_api_unittest.cc:1: // Copyright (c) 2013 The Chromium Authors. All rights ...
7 years, 7 months ago (2013-05-03 01:48:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/14699002/10001
7 years, 7 months ago (2013-05-03 01:49:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/14699002/25001
7 years, 7 months ago (2013-05-03 02:34:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=37864
7 years, 7 months ago (2013-05-03 04:53:10 UTC) #6
Nico
cocoa lgtm
7 years, 7 months ago (2013-05-03 04:55:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/14699002/35001
7 years, 7 months ago (2013-05-06 20:52:35 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=124533
7 years, 7 months ago (2013-05-06 21:57:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/14699002/35001
7 years, 7 months ago (2013-05-06 22:27:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/14699002/67001
7 years, 7 months ago (2013-05-08 22:21:10 UTC) #11
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 06:39:22 UTC) #12
Message was sent while issue was closed. 
Change committed as 199151

Powered by Google App Engine
This is Rietveld 408576698