Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4415)

Unified Diff: chrome/common/chrome_notification_types.h

Issue 14699002: Move BrowserAction references from ExtensionPrefs to ExtensionActionAPI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_notification_types.h
diff --git a/chrome/common/chrome_notification_types.h b/chrome/common/chrome_notification_types.h
index 6c5c11f375f764f681355f17df852e4d8db357ac..ce9ecf6668ab19d1cab9cabd2af877bffc6e4669 100644
--- a/chrome/common/chrome_notification_types.h
+++ b/chrome/common/chrome_notification_types.h
@@ -573,7 +573,8 @@ enum NotificationType {
NOTIFICATION_EXTENSION_PAGE_ACTION_COUNT_CHANGED,
// Sent when a browser action's visibility has changed. The source is the
- // ExtensionPrefs* that changed. The details are a Extension*.
+ // ExtensionPrefs* that changed, and the details are a std::string with the
+ // extension's ID.
NOTIFICATION_EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED,
// Sent when a page action's visibility has changed. The source is the
@@ -596,18 +597,21 @@ enum NotificationType {
NOTIFICATION_EXTENSION_COMMAND_ADDED,
// Sent when an extension command shortcut for a browser action is activated
- // on Mac. The source is the profile and the details is a std::string
- // containing an extension ID.
+ // on Mac. The source is the profile and the details is a std::pair of a
+ // std::string containing an extension ID and a gfx::NativeWindow for the
+ // associated window.
NOTIFICATION_EXTENSION_COMMAND_BROWSER_ACTION_MAC,
// Sent when an extension command shortcut for a page action is activated
- // on Mac. The source is the profile and the details is a std::string
- // containing an extension ID.
+ // on Mac. The source is the profile and the details is a std::pair of a
+ // std::string containing an extension ID and a gfx::NativeWindow for the
+ // associated window.
NOTIFICATION_EXTENSION_COMMAND_PAGE_ACTION_MAC,
// Sent when an extension command shortcut for a script badge is activated
- // on Mac. The source is the profile and the details is a std::string
- // containing an extension ID.
+ // on Mac. The source is the profile and the details is a std::pair of a
+ // std::string containing an extension ID and a gfx::NativeWindow for the
+ // associated window.
NOTIFICATION_EXTENSION_COMMAND_SCRIPT_BADGE_MAC,
// A new extension RenderViewHost has been registered. The details are
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698