Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm

Issue 14699002: Move BrowserAction references from ExtensionPrefs to ExtensionActionAPI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu.h" 5 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu.h"
6 6
7 #include "base/prefs/pref_change_registrar.h" 7 #include "base/prefs/pref_change_registrar.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/strings/sys_string_conversions.h" 9 #include "base/strings/sys_string_conversions.h"
10 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
10 #include "chrome/browser/extensions/extension_action.h" 11 #include "chrome/browser/extensions/extension_action.h"
11 #include "chrome/browser/extensions/extension_action_manager.h" 12 #include "chrome/browser/extensions/extension_action_manager.h"
12 #include "chrome/browser/extensions/extension_service.h" 13 #include "chrome/browser/extensions/extension_service.h"
13 #include "chrome/browser/extensions/extension_system.h" 14 #include "chrome/browser/extensions/extension_system.h"
14 #include "chrome/browser/extensions/extension_tab_util.h" 15 #include "chrome/browser/extensions/extension_tab_util.h"
15 #include "chrome/browser/extensions/extension_uninstall_dialog.h" 16 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
16 #include "chrome/browser/profiles/profile.h" 17 #include "chrome/browser/profiles/profile.h"
17 #include "chrome/browser/ui/browser.h" 18 #include "chrome/browser/ui/browser.h"
18 #include "chrome/browser/ui/browser_finder.h" 19 #include "chrome/browser/ui/browser_finder.h"
19 #include "chrome/browser/ui/chrome_pages.h" 20 #include "chrome/browser/ui/chrome_pages.h"
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 case kExtensionContextOptions: { 208 case kExtensionContextOptions: {
208 DCHECK(!extensions::ManifestURL::GetOptionsPage(extension_).is_empty()); 209 DCHECK(!extensions::ManifestURL::GetOptionsPage(extension_).is_empty());
209 ExtensionTabUtil::OpenOptionsPage(extension_, browser_); 210 ExtensionTabUtil::OpenOptionsPage(extension_, browser_);
210 break; 211 break;
211 } 212 }
212 case kExtensionContextUninstall: { 213 case kExtensionContextUninstall: {
213 uninstaller_.reset(new AsyncUninstaller(extension_, browser_)); 214 uninstaller_.reset(new AsyncUninstaller(extension_, browser_));
214 break; 215 break;
215 } 216 }
216 case kExtensionContextHide: { 217 case kExtensionContextHide: {
217 ExtensionService* extension_service = extensions::ExtensionSystem::Get( 218 extensions::ExtensionActionAPI::SetBrowserActionVisibility(
218 browser_->profile())->extension_service(); 219 extensions::ExtensionSystem::Get(browser_->profile())->
219 extension_service->extension_prefs()-> 220 extension_service()->extension_prefs(),
220 SetBrowserActionVisibility(extension_, false); 221 extension_->id(),
222 false);
221 break; 223 break;
222 } 224 }
223 case kExtensionContextManage: { 225 case kExtensionContextManage: {
224 chrome::ShowExtensions(browser_, extension_->id()); 226 chrome::ShowExtensions(browser_, extension_->id());
225 break; 227 break;
226 } 228 }
227 case kExtensionContextInspect: { 229 case kExtensionContextInspect: {
228 BrowserWindowCocoa* window = 230 BrowserWindowCocoa* window =
229 static_cast<BrowserWindowCocoa*>(browser_->window()); 231 static_cast<BrowserWindowCocoa*>(browser_->window());
230 ToolbarController* toolbarController = 232 ToolbarController* toolbarController =
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 - (BOOL)validateMenuItem:(NSMenuItem*)menuItem { 276 - (BOOL)validateMenuItem:(NSMenuItem*)menuItem {
275 if ([menuItem tag] == kExtensionContextOptions) { 277 if ([menuItem tag] == kExtensionContextOptions) {
276 // Disable 'Options' if there are no options to set. 278 // Disable 'Options' if there are no options to set.
277 return extensions::ManifestURL:: 279 return extensions::ManifestURL::
278 GetOptionsPage(extension_).spec().length() > 0; 280 GetOptionsPage(extension_).spec().length() > 0;
279 } 281 }
280 return YES; 282 return YES;
281 } 283 }
282 284
283 @end 285 @end
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_toolbar_model.cc ('k') | chrome/browser/ui/views/browser_actions_container_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698