chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm - Issue 14699002: Move BrowserAction references from ExtensionPrefs to ExtensionActionAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm

Issue 14699002: Move BrowserAction references from ExtensionPrefs to ExtensionActionAPI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_toolbar_model.cc ('k') | chrome/browser/ui/views/browser_actions_container_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm

index 58adaa8e2c89f3019a10f3984857be5bb901ca9b..77b5159049cbd22c1dee898483447674e56a2917 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm

@@ -7,6 +7,7 @@

#include "base/prefs/pref_change_registrar.h"

#include "base/prefs/pref_service.h"

#include "base/strings/sys_string_conversions.h"

+#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"

#include "chrome/browser/extensions/extension_action.h"

#include "chrome/browser/extensions/extension_action_manager.h"

#include "chrome/browser/extensions/extension_service.h"

@@ -214,10 +215,11 @@ enum {

break;

}

case kExtensionContextHide: {

- ExtensionService* extension_service = extensions::ExtensionSystem::Get(

- browser_->profile())->extension_service();

- extension_service->extension_prefs()->

- SetBrowserActionVisibility(extension_, false);

+ extensions::ExtensionActionAPI::SetBrowserActionVisibility(

+ extensions::ExtensionSystem::Get(browser_->profile())->

+ extension_service()->extension_prefs(),

+ extension_->id(),

+ false);

break;

}

case kExtensionContextManage: {