Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 14699002: Move BrowserAction references from ExtensionPrefs to ExtensionActionAPI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/values.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/developer_private/developer_private_api. h" 5 #include "chrome/browser/extensions/api/developer_private/developer_private_api. h"
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/i18n/file_util_icu.h" 9 #include "base/i18n/file_util_icu.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
11 #include "base/utf_string_conversions.h" 11 #include "base/utf_string_conversions.h"
12 #include "base/values.h" 12 #include "base/values.h"
13 #include "chrome/browser/devtools/devtools_window.h" 13 #include "chrome/browser/devtools/devtools_window.h"
14 #include "chrome/browser/extensions/api/developer_private/developer_private_api_ factory.h" 14 #include "chrome/browser/extensions/api/developer_private/developer_private_api_ factory.h"
15 #include "chrome/browser/extensions/api/developer_private/entry_picker.h" 15 #include "chrome/browser/extensions/api/developer_private/entry_picker.h"
16 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
16 #include "chrome/browser/extensions/extension_disabled_ui.h" 17 #include "chrome/browser/extensions/extension_disabled_ui.h"
17 #include "chrome/browser/extensions/extension_error_reporter.h" 18 #include "chrome/browser/extensions/extension_error_reporter.h"
18 #include "chrome/browser/extensions/extension_service.h" 19 #include "chrome/browser/extensions/extension_service.h"
19 #include "chrome/browser/extensions/extension_system.h" 20 #include "chrome/browser/extensions/extension_system.h"
20 #include "chrome/browser/extensions/management_policy.h" 21 #include "chrome/browser/extensions/management_policy.h"
21 #include "chrome/browser/extensions/shell_window_registry.h" 22 #include "chrome/browser/extensions/shell_window_registry.h"
22 #include "chrome/browser/extensions/unpacked_installer.h" 23 #include "chrome/browser/extensions/unpacked_installer.h"
23 #include "chrome/browser/extensions/updater/extension_updater.h" 24 #include "chrome/browser/extensions/updater/extension_updater.h"
24 #include "chrome/browser/platform_util.h" 25 #include "chrome/browser/platform_util.h"
25 #include "chrome/browser/profiles/profile.h" 26 #include "chrome/browser/profiles/profile.h"
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
583 // Released by OnRequirementsChecked. 584 // Released by OnRequirementsChecked.
584 AddRef(); 585 AddRef();
585 requirements_checker_->Check( 586 requirements_checker_->Check(
586 extension, 587 extension,
587 base::Bind(&DeveloperPrivateEnableFunction::OnRequirementsChecked, 588 base::Bind(&DeveloperPrivateEnableFunction::OnRequirementsChecked,
588 this, extension_id)); 589 this, extension_id));
589 } else { 590 } else {
590 service->EnableExtension(extension_id); 591 service->EnableExtension(extension_id);
591 592
592 // Make sure any browser action contained within it is not hidden. 593 // Make sure any browser action contained within it is not hidden.
593 prefs->SetBrowserActionVisibility(extension, true); 594 ExtensionActionAPI::SetBrowserActionVisibility(
595 prefs, extension->id(), true);
594 } 596 }
595 } else { 597 } else {
596 service->DisableExtension(extension_id, Extension::DISABLE_USER_ACTION); 598 service->DisableExtension(extension_id, Extension::DISABLE_USER_ACTION);
597 } 599 }
598 return true; 600 return true;
599 } 601 }
600 602
601 void DeveloperPrivateEnableFunction::OnRequirementsChecked( 603 void DeveloperPrivateEnableFunction::OnRequirementsChecked(
602 std::string extension_id, 604 std::string extension_id,
603 std::vector<std::string> requirements_errors) { 605 std::vector<std::string> requirements_errors) {
(...skipping 675 matching lines...) Expand 10 before | Expand all | Expand 10 after
1279 1281
1280 #undef SET_STRING 1282 #undef SET_STRING
1281 return true; 1283 return true;
1282 } 1284 }
1283 1285
1284 DeveloperPrivateGetStringsFunction::~DeveloperPrivateGetStringsFunction() {} 1286 DeveloperPrivateGetStringsFunction::~DeveloperPrivateGetStringsFunction() {}
1285 1287
1286 } // namespace api 1288 } // namespace api
1287 1289
1288 } // namespace extensions 1290 } // namespace extensions
OLDNEW
« no previous file with comments | « base/values.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698