Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1469863003: Cleanup SurfaceVisibility code. (Closed)

Created:
5 years, 1 month ago by sohanjg
Modified:
5 years ago
Reviewers:
bbudge, sky, dcheng, piman
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup SurfaceVisibility code. BUG=None CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/eb453b4a2206bc5d022346464b701c5bedcaf681 Cr-Commit-Position: refs/heads/master@{#362203}

Patch Set 1 #

Total comments: 2

Patch Set 2 : cleanup surface visibility completely. #

Total comments: 2

Patch Set 3 : cleanup components and mojo too. #

Patch Set 4 : rebase.. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -172 lines) Patch
M cc/output/delegating_renderer.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 2 3 1 chunk +0 lines, -82 lines 0 comments Download
M cc/test/test_context_support.h View 1 3 chunks +0 lines, -6 lines 0 comments Download
M cc/test/test_context_support.cc View 1 2 chunks +0 lines, -11 lines 0 comments Download
M components/mus/gles2/command_buffer_local.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/gles2/command_buffer_local.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/context_support.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/client/gpu_control.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 30 (11 generated)
sohanjg
Missed this in the last cleanup. Please take a look, thanks.
5 years, 1 month ago (2015-11-23 14:42:05 UTC) #2
piman
https://codereview.chromium.org/1469863003/diff/1/gpu/command_buffer/client/gles2_implementation.cc File gpu/command_buffer/client/gles2_implementation.cc (right): https://codereview.chromium.org/1469863003/diff/1/gpu/command_buffer/client/gles2_implementation.cc#newcode343 gpu/command_buffer/client/gles2_implementation.cc:343: void GLES2Implementation::SetSurfaceVisible(bool visible) { This doesn't do anything useful ...
5 years, 1 month ago (2015-11-23 19:22:51 UTC) #3
sohanjg
Please take a look, thanks. https://codereview.chromium.org/1469863003/diff/1/gpu/command_buffer/client/gles2_implementation.cc File gpu/command_buffer/client/gles2_implementation.cc (right): https://codereview.chromium.org/1469863003/diff/1/gpu/command_buffer/client/gles2_implementation.cc#newcode343 gpu/command_buffer/client/gles2_implementation.cc:343: void GLES2Implementation::SetSurfaceVisible(bool visible) { ...
5 years ago (2015-11-24 11:28:52 UTC) #4
piman
lgtm https://codereview.chromium.org/1469863003/diff/20001/cc/output/delegating_renderer.cc File cc/output/delegating_renderer.cc (right): https://codereview.chromium.org/1469863003/diff/20001/cc/output/delegating_renderer.cc#newcode119 cc/output/delegating_renderer.cc:119: // upon. nit: You can remove this comment ...
5 years ago (2015-11-24 21:43:52 UTC) #6
sohanjg
Cleaned up mojo and components/mus too. https://codereview.chromium.org/1469863003/diff/20001/cc/output/delegating_renderer.cc File cc/output/delegating_renderer.cc (right): https://codereview.chromium.org/1469863003/diff/20001/cc/output/delegating_renderer.cc#newcode119 cc/output/delegating_renderer.cc:119: // upon. On ...
5 years ago (2015-11-25 07:37:17 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469863003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469863003/40001
5 years ago (2015-11-25 07:37:37 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/99165) ios_rel_device_ninja on ...
5 years ago (2015-11-25 07:39:44 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469863003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469863003/60001
5 years ago (2015-11-25 12:29:18 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 13:54:40 UTC) #15
sohanjg
+ sky@ for components/mus, mojo + dchecng@ for ipc + bbudge@ for ppapi Can you ...
5 years ago (2015-11-26 05:19:00 UTC) #16
sohanjg
On 2015/11/26 05:19:00, sohanjg wrote: > + sky@ for components/mus, mojo > + dchecng@ for ...
5 years ago (2015-11-27 01:04:14 UTC) #18
dcheng
Removal-only ipc changes lgtm
5 years ago (2015-11-27 01:28:35 UTC) #19
dcheng
Removal-only ipc changes lgtm
5 years ago (2015-11-27 01:28:35 UTC) #20
sohanjg
On 2015/11/27 01:28:35, dcheng wrote: > Removal-only ipc changes lgtm sky@ can you pls have ...
5 years ago (2015-11-27 19:08:02 UTC) #21
sky
LGTM
5 years ago (2015-11-30 17:14:25 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469863003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469863003/60001
5 years ago (2015-11-30 18:00:14 UTC) #25
bbudge
ppapi lgtm
5 years ago (2015-11-30 18:06:13 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-11-30 20:11:27 UTC) #28
commit-bot: I haz the power
5 years ago (2015-11-30 20:12:37 UTC) #30
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/eb453b4a2206bc5d022346464b701c5bedcaf681
Cr-Commit-Position: refs/heads/master@{#362203}

Powered by Google App Engine
This is Rietveld 408576698