Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace (Closed)

Created:
5 years, 1 month ago by oshima
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, Inactive, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, eae+blinkwatch, estade+watch_chromium.org, gcasto+watchlist_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+watchlist-passwords_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, rwlbuis, rouslan+autofill_chromium.org, sof, vabr+watchlistautofill_chromium.org, vabr+watchlistpasswordmanager_chromium.org, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return VisualViewport coords in boundsInViewportSpace Rename it to boundsInViewport BUG=459591, 485650 R=bokan@chromium.org Committed: https://crrev.com/09771f410bc3eecd83a8cf03631572126371190f Cr-Commit-Position: refs/heads/master@{#362806}

Patch Set 1 : #

Total comments: 15

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -69 lines) Patch
M components/autofill/content/renderer/autofill_agent.cc View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 3 chunks +2 lines, -8 lines 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 1 1 chunk +3 lines, -14 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebElement.h View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 45 (24 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463723003/1
5 years, 1 month ago (2015-11-20 08:35:49 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/143768)
5 years, 1 month ago (2015-11-20 09:29:11 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463723003/20001
5 years, 1 month ago (2015-11-21 02:21:54 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-21 04:30:59 UTC) #10
oshima
tommycli@ -> pepper_plugin_instnace_iml.cc bokan@ -> everything else https://codereview.chromium.org/1463723003/diff/20001/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (left): https://codereview.chromium.org/1463723003/diff/20001/content/renderer/pepper/pepper_plugin_instance_impl.cc#oldcode1084 content/renderer/pepper/pepper_plugin_instance_impl.cc:1084: RecordFlashClickSizeMetric(bounds.width, bounds.height); ...
5 years, 1 month ago (2015-11-23 22:14:50 UTC) #13
vabr (Chromium)
//components/autofill LGTM with the comments below addressed and the following behaviour confirmed: (1) Go to ...
5 years ago (2015-11-24 09:12:27 UTC) #16
bokan
https://codereview.chromium.org/1463723003/diff/20001/third_party/WebKit/Source/core/testing/Internals.cpp File third_party/WebKit/Source/core/testing/Internals.cpp (right): https://codereview.chromium.org/1463723003/diff/20001/third_party/WebKit/Source/core/testing/Internals.cpp#newcode2426 third_party/WebKit/Source/core/testing/Internals.cpp:2426: /* Remove rather than comment https://codereview.chromium.org/1463723003/diff/20001/third_party/WebKit/Source/core/testing/Internals.h File third_party/WebKit/Source/core/testing/Internals.h (right): ...
5 years ago (2015-11-24 20:59:24 UTC) #17
oshima
PTAL https://codereview.chromium.org/1463723003/diff/20001/components/autofill/content/renderer/autofill_agent.cc File components/autofill/content/renderer/autofill_agent.cc (right): https://codereview.chromium.org/1463723003/diff/20001/components/autofill/content/renderer/autofill_agent.cc#newcode750 components/autofill/content/renderer/autofill_agent.cc:750: blink::WebRect bounding_box_in_viewport = element_.boundsInViewport(); On 2015/11/24 09:12:27, vabr ...
5 years ago (2015-11-24 23:42:10 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463723003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463723003/60001
5 years ago (2015-11-24 23:44:13 UTC) #23
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 04:19:34 UTC) #25
vabr (Chromium)
//components/autofill LGTM
5 years ago (2015-11-25 07:24:17 UTC) #26
bokan
lgtm
5 years ago (2015-11-25 14:06:40 UTC) #27
oshima
+tkent/piman for OWNERS review tkent@ -> third_party/WebKit piman@ -> content/renderer/
5 years ago (2015-11-25 19:20:05 UTC) #31
piman
lgtm
5 years ago (2015-11-26 00:06:36 UTC) #32
tkent
third_party/WebKit LGTM
5 years ago (2015-11-26 00:37:47 UTC) #33
tommycli
lgtm
5 years ago (2015-12-02 18:33:10 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463723003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463723003/60001
5 years ago (2015-12-02 18:47:15 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/101894) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-12-02 18:50:20 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463723003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463723003/100001
5 years ago (2015-12-02 20:08:18 UTC) #41
commit-bot: I haz the power
Committed patchset #3 (id:100001)
5 years ago (2015-12-02 22:13:59 UTC) #43
commit-bot: I haz the power
5 years ago (2015-12-02 22:14:48 UTC) #45
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/09771f410bc3eecd83a8cf03631572126371190f
Cr-Commit-Position: refs/heads/master@{#362806}

Powered by Google App Engine
This is Rietveld 408576698