Return VisualViewport coords in boundsInViewportSpace

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/i18n/case_conversion.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 1402 matching lines @@
   FormFieldData field;
   form_util::FindFormAndFieldForFormControlElement(user_input, &form, &field);
 
   blink::WebInputElement selected_element = user_input;
   if (show_on_password_field && !selected_element.isPasswordField()) {
     WebInputToPasswordInfoMap::const_iterator iter =
         web_input_to_password_info_.find(user_input);
     DCHECK(iter != web_input_to_password_info_.end());
     selected_element = iter->second.password_field;
   }
-  gfx::Rect bounding_box(selected_element.boundsInViewportSpace());
 
   blink::WebInputElement username;
   if (!show_on_password_field || !user_input.isPasswordField()) {
     username = user_input;
   }
   WebElementToPasswordInfoKeyMap::const_iterator key_it =
       web_element_to_password_info_key_.find(user_input);
   DCHECK(key_it != web_element_to_password_info_key_.end());
 
-  float scale =
-      render_frame()->GetRenderView()->GetWebView()->pageScaleFactor();
-  gfx::RectF bounding_box_scaled(bounding_box.x() * scale,
-                                 bounding_box.y() * scale,
-                                 bounding_box.width() * scale,
-                                 bounding_box.height() * scale);
   int options = 0;
   if (show_all)
     options |= SHOW_ALL;
   if (show_on_password_field)
     options |= IS_PASSWORD_FIELD;
   base::string16 username_string(
       username.isNull() ? base::string16()
                         : static_cast<base::string16>(user_input.value()));
+
+  blink::WebRect bounding_box_in_viewport = selected_element.boundsInViewport();

[vabr (Chromium), 2015/11/24 09:12:27]

ditto

[oshima, 2015/11/24 23:42:10]

Done.

+
   Send(new AutofillHostMsg_ShowPasswordSuggestions(
       routing_id(), key_it->second, field.text_direction, username_string,
-      options, bounding_box_scaled));
+      options, gfx::RectF(bounding_box_in_viewport)));
   username_query_prefix_ = username_string;
   return CanShowSuggestion(fill_data, username_string, show_all);
 }
 
 void PasswordAutofillAgent::FrameClosing() {
   for (auto const& iter : web_input_to_password_info_) {
     web_element_to_password_info_key_.erase(iter.first);
     password_to_username_.erase(iter.second.password_field);
   }
   web_input_to_password_info_.clear();
@@ skipping 44 matching lines @@
 }
 
 bool PasswordAutofillAgent::ProvisionallySavedPasswordIsValid() {
   return provisionally_saved_form_ &&
          !provisionally_saved_form_->username_value.empty() &&
          !(provisionally_saved_form_->password_value.empty() &&
          provisionally_saved_form_->new_password_value.empty());
 }
 
 }  // namespace autofill