components/autofill/content/renderer/form_autofill_util.cc - Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/form_autofill_util.cc

Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/form_autofill_util.h ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/form_autofill_util.cc

diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc

index e1869e8799f5df50391c4c215d4eb302506961d2..5c7f0d6102e281c6fa8f457f2e2e7e5acb38a5be 100644

--- a/components/autofill/content/renderer/form_autofill_util.cc

+++ b/components/autofill/content/renderer/form_autofill_util.cc

@@ -1636,14 +1636,6 @@ bool IsWebElementEmpty(const blink::WebElement& root) {

return true;

}

-gfx::RectF GetScaledBoundingBox(float scale, WebElement* element) {

- gfx::Rect bounding_box(element->boundsInViewportSpace());

- return gfx::RectF(bounding_box.x() * scale,

- bounding_box.y() * scale,

- bounding_box.width() * scale,

- bounding_box.height() * scale);

void PreviewSuggestion(const base::string16& suggestion,

const base::string16& user_input,

blink::WebFormControlElement* input_element) {