Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp

Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | third_party/WebKit/public/web/WebElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp b/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
index abe1920a61b5281abfb28d33ecd5d54b5904d720..62554c72d2e7febc885ec3f6a263c32b950dafb7 100644
--- a/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
@@ -368,7 +368,7 @@ TEST_F(WebPluginContainerTest, GestureLongPressReachesPlugin)
EXPECT_EQ(WebInputEvent::Undefined, testPlugin->getLastInputEventType());
// Next, send an event that does hit the plugin, and verify it does receive it.
- WebRect rect = pluginContainerOneElement.boundsInViewportSpace();
+ WebRect rect = pluginContainerOneElement.boundsInViewport();
event.x = rect.x + rect.width / 2;
event.y = rect.y + rect.height / 2;
@@ -395,7 +395,7 @@ TEST_F(WebPluginContainerTest, IsRectTopmostTest)
toWebPluginContainerImpl(getWebPluginContainer(webView, WebString::fromUTF8("translated-plugin")));
pluginContainerImpl->setFrameRect(IntRect(0, 0, 300, 300));
- WebRect rect = pluginContainerImpl->element().boundsInViewportSpace();
+ WebRect rect = pluginContainerImpl->element().boundsInViewport();
EXPECT_TRUE(pluginContainerImpl->isRectTopmost(rect));
// Cause the plugin's frame to be detached.
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | third_party/WebKit/public/web/WebElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698