Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: components/autofill/content/renderer/password_generation_agent.cc

Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_generation_agent.cc
diff --git a/components/autofill/content/renderer/password_generation_agent.cc b/components/autofill/content/renderer/password_generation_agent.cc
index 17dfbeaeb1f8fadc0decf6f55cc8cdb2572baac1..4d1c8cc41eafca86a055ebf008fce5df223a2e90 100644
--- a/components/autofill/content/renderer/password_generation_agent.cc
+++ b/components/autofill/content/renderer/password_generation_agent.cc
@@ -411,27 +411,16 @@ bool PasswordGenerationAgent::TextDidChangeInTextField(
}
void PasswordGenerationAgent::ShowGenerationPopup() {
- gfx::RectF bounding_box_scaled = form_util::GetScaledBoundingBox(
- render_frame()->GetRenderView()->GetWebView()->pageScaleFactor(),
- &generation_element_);
-
Send(new AutofillHostMsg_ShowPasswordGenerationPopup(
- routing_id(),
- bounding_box_scaled,
- generation_element_.maxLength(),
- *generation_form_data_->form));
+ routing_id(), gfx::RectF(generation_element_.boundsInViewport()),
+ generation_element_.maxLength(), *generation_form_data_->form));
generation_popup_shown_ = true;
}
void PasswordGenerationAgent::ShowEditingPopup() {
- gfx::RectF bounding_box_scaled = form_util::GetScaledBoundingBox(
- render_frame()->GetRenderView()->GetWebView()->pageScaleFactor(),
- &generation_element_);
-
Send(new AutofillHostMsg_ShowPasswordEditingPopup(
- routing_id(),
- bounding_box_scaled,
+ routing_id(), gfx::RectF(generation_element_.boundsInViewport()),
*generation_form_data_->form));
editing_popup_shown_ = true;

Powered by Google App Engine
This is Rietveld 408576698