Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 145873007: Cast: Added missing DCHECKs to ThreadChecker calls and minor cleanup. (Closed)

Created:
6 years, 10 months ago by imcheng
Modified:
6 years, 10 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: Added missing DCHECKs to ThreadChecker calls and minor cleanup. Also included in this CL are: - Removed task_runner in constructor of RawEventSubscriber impls - Minor fixes in unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250847

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -104 lines) Patch
M media/cast/audio_receiver/audio_receiver.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/logging/logging_impl_unittest.cc View 9 chunks +11 lines, -12 lines 0 comments Download
M media/cast/logging/logging_raw_unittest.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M media/cast/logging/simple_event_subscriber.h View 2 chunks +2 lines, -8 lines 0 comments Download
M media/cast/logging/simple_event_subscriber.cc View 1 chunk +8 lines, -11 lines 0 comments Download
M media/cast/logging/simple_event_subscriber_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/cast/rtcp/receiver_rtcp_event_subscriber.h View 2 chunks +1 line, -7 lines 0 comments Download
M media/cast/rtcp/receiver_rtcp_event_subscriber.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M media/cast/rtcp/receiver_rtcp_event_subscriber_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
media/cast/rtcp/sender_rtcp_event_subscriber.h View 2 chunks +2 lines, -11 lines 0 comments Download
M media/cast/rtcp/sender_rtcp_event_subscriber.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M media/cast/rtcp/sender_rtcp_event_subscriber_unittest.cc View 6 chunks +10 lines, -13 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/cast/video_receiver/video_receiver.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/video_sender/video_sender.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
imcheng
6 years, 10 months ago (2014-02-12 09:15:53 UTC) #1
Alpha Left Google
lgtm
6 years, 10 months ago (2014-02-12 16:54:20 UTC) #2
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-12 17:23:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/145873007/20001
6 years, 10 months ago (2014-02-12 17:25:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 17:25:28 UTC) #5
commit-bot: I haz the power
Failed to apply patch for media/cast/video_receiver/video_receiver.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-12 17:25:29 UTC) #6
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-12 18:09:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/145873007/90001
6 years, 10 months ago (2014-02-12 18:10:50 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 23:46:30 UTC) #9
Message was sent while issue was closed. 
Change committed as 250847

Powered by Google App Engine
This is Rietveld 408576698