Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: media/cast/logging/logging_raw_unittest.cc

Issue 145873007: Cast: Added missing DCHECKs to ThreadChecker calls and minor cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/logging/logging_impl_unittest.cc ('k') | media/cast/logging/simple_event_subscriber.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/logging/logging_raw_unittest.cc
diff --git a/media/cast/logging/logging_raw_unittest.cc b/media/cast/logging/logging_raw_unittest.cc
index 44460702f3d2851d5fcc29656323973e84d8bf0a..135aed5ea1b121a9a4792d53dd1cdf5d113190b8 100644
--- a/media/cast/logging/logging_raw_unittest.cc
+++ b/media/cast/logging/logging_raw_unittest.cc
@@ -2,12 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "base/memory/scoped_ptr.h"
-#include "base/test/simple_test_tick_clock.h"
#include "media/cast/logging/logging_defines.h"
#include "media/cast/logging/logging_raw.h"
#include "media/cast/logging/simple_event_subscriber.h"
-#include "media/cast/test/fake_single_thread_task_runner.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace media {
@@ -15,17 +12,13 @@ namespace cast {
class LoggingRawTest : public ::testing::Test {
protected:
- LoggingRawTest()
- : task_runner_(new test::FakeSingleThreadTaskRunner(&testing_clock_)),
- event_subscriber_(task_runner_) {
+ LoggingRawTest() {
raw_.AddSubscriber(&event_subscriber_);
}
virtual ~LoggingRawTest() { raw_.RemoveSubscriber(&event_subscriber_); }
LoggingRaw raw_;
- base::SimpleTestTickClock testing_clock_;
- scoped_refptr<test::FakeSingleThreadTaskRunner> task_runner_;
SimpleEventSubscriber event_subscriber_;
std::vector<FrameEvent> frame_events_;
std::vector<PacketEvent> packet_events_;
@@ -153,7 +146,7 @@ TEST_F(LoggingRawTest, GenericEvent) {
}
TEST_F(LoggingRawTest, MultipleSubscribers) {
- SimpleEventSubscriber event_subscriber_2(task_runner_);
+ SimpleEventSubscriber event_subscriber_2;
// Now raw_ has two subscribers.
raw_.AddSubscriber(&event_subscriber_2);
« no previous file with comments | « media/cast/logging/logging_impl_unittest.cc ('k') | media/cast/logging/simple_event_subscriber.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698