Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Unified Diff: media/cast/rtcp/sender_rtcp_event_subscriber.cc

Issue 145873007: Cast: Added missing DCHECKs to ThreadChecker calls and minor cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/rtcp/sender_rtcp_event_subscriber.cc
diff --git a/media/cast/rtcp/sender_rtcp_event_subscriber.cc b/media/cast/rtcp/sender_rtcp_event_subscriber.cc
index f16ff01ef6c28f45d30c0bf91064d7bc6fd547dd..7b82f4a7e52cea9f6a423addb0d5f79581aad0fb 100644
--- a/media/cast/rtcp/sender_rtcp_event_subscriber.cc
+++ b/media/cast/rtcp/sender_rtcp_event_subscriber.cc
@@ -6,28 +6,25 @@
#include <utility>
-#include "base/single_thread_task_runner.h"
-#include "media/cast/cast_environment.h"
+#include "base/logging.h"
#include "media/cast/rtcp/rtcp_defines.h"
namespace media {
namespace cast {
SenderRtcpEventSubscriber::SenderRtcpEventSubscriber(
- const scoped_refptr<base::SingleThreadTaskRunner>& main_thread_proxy,
const size_t max_size_to_retain)
: max_size_to_retain_(max_size_to_retain) {
- DCHECK(main_thread_proxy->RunsTasksOnCurrentThread());
DCHECK(max_size_to_retain_ > 0u);
}
SenderRtcpEventSubscriber::~SenderRtcpEventSubscriber() {
- thread_checker_.CalledOnValidThread();
+ DCHECK(thread_checker_.CalledOnValidThread());
}
void SenderRtcpEventSubscriber::OnReceiveFrameEvent(
const FrameEvent& frame_event) {
- thread_checker_.CalledOnValidThread();
+ DCHECK(thread_checker_.CalledOnValidThread());
if (frame_event.type != kVideoFrameCaptured &&
frame_event.type != kVideoFrameSentToEncoder &&
frame_event.type != kVideoFrameEncoded) {
@@ -68,19 +65,19 @@ void SenderRtcpEventSubscriber::OnReceiveFrameEvent(
void SenderRtcpEventSubscriber::OnReceivePacketEvent(
const PacketEvent& packet_event) {
- thread_checker_.CalledOnValidThread();
+ DCHECK(thread_checker_.CalledOnValidThread());
// Do nothing as RTP sender is not interested in packet events for RTCP.
}
void SenderRtcpEventSubscriber::OnReceiveGenericEvent(
const GenericEvent& generic_event) {
- thread_checker_.CalledOnValidThread();
+ DCHECK(thread_checker_.CalledOnValidThread());
// Do nothing as RTP sender is not interested in generic events for RTCP.
}
void SenderRtcpEventSubscriber::GetRtcpEventsAndReset(
RtcpEventMap* rtcp_events) {
- thread_checker_.CalledOnValidThread();
+ DCHECK(thread_checker_.CalledOnValidThread());
rtcp_events->swap(rtcp_events_);
rtcp_events_.clear();
}
« no previous file with comments | « media/cast/rtcp/sender_rtcp_event_subscriber.h ('k') | media/cast/rtcp/sender_rtcp_event_subscriber_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698