Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: media/cast/logging/simple_event_subscriber.cc

Issue 145873007: Cast: Added missing DCHECKs to ThreadChecker calls and minor cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/cast/logging/simple_event_subscriber.h" 5 #include "media/cast/logging/simple_event_subscriber.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/single_thread_task_runner.h"
11 10
12 namespace media { 11 namespace media {
13 namespace cast { 12 namespace cast {
14 13
15 SimpleEventSubscriber::SimpleEventSubscriber( 14 SimpleEventSubscriber::SimpleEventSubscriber() {}
16 const scoped_refptr<base::SingleThreadTaskRunner>& main_thread_proxy) {
17 DCHECK(main_thread_proxy->RunsTasksOnCurrentThread());
18 }
19 15
20 SimpleEventSubscriber::~SimpleEventSubscriber() { 16 SimpleEventSubscriber::~SimpleEventSubscriber() {
21 thread_checker_.CalledOnValidThread(); 17 DCHECK(thread_checker_.CalledOnValidThread());
22 } 18 }
23 19
24 void SimpleEventSubscriber::OnReceiveFrameEvent(const FrameEvent& frame_event) { 20 void SimpleEventSubscriber::OnReceiveFrameEvent(const FrameEvent& frame_event) {
25 thread_checker_.CalledOnValidThread(); 21 DCHECK(thread_checker_.CalledOnValidThread());
26 frame_events_.push_back(frame_event); 22 frame_events_.push_back(frame_event);
27 } 23 }
28 24
29 void SimpleEventSubscriber::OnReceivePacketEvent( 25 void SimpleEventSubscriber::OnReceivePacketEvent(
30 const PacketEvent& packet_event) { 26 const PacketEvent& packet_event) {
31 thread_checker_.CalledOnValidThread(); 27 DCHECK(thread_checker_.CalledOnValidThread());
32 packet_events_.push_back(packet_event); 28 packet_events_.push_back(packet_event);
33 } 29 }
34 30
35 void SimpleEventSubscriber::OnReceiveGenericEvent( 31 void SimpleEventSubscriber::OnReceiveGenericEvent(
36 const GenericEvent& generic_event) { 32 const GenericEvent& generic_event) {
33 DCHECK(thread_checker_.CalledOnValidThread());
37 generic_events_.push_back(generic_event); 34 generic_events_.push_back(generic_event);
38 } 35 }
39 36
40 void SimpleEventSubscriber::GetFrameEventsAndReset( 37 void SimpleEventSubscriber::GetFrameEventsAndReset(
41 std::vector<FrameEvent>* frame_events) { 38 std::vector<FrameEvent>* frame_events) {
42 thread_checker_.CalledOnValidThread(); 39 DCHECK(thread_checker_.CalledOnValidThread());
43 frame_events->swap(frame_events_); 40 frame_events->swap(frame_events_);
44 frame_events_.clear(); 41 frame_events_.clear();
45 } 42 }
46 43
47 void SimpleEventSubscriber::GetPacketEventsAndReset( 44 void SimpleEventSubscriber::GetPacketEventsAndReset(
48 std::vector<PacketEvent>* packet_events) { 45 std::vector<PacketEvent>* packet_events) {
49 thread_checker_.CalledOnValidThread(); 46 DCHECK(thread_checker_.CalledOnValidThread());
50 packet_events->swap(packet_events_); 47 packet_events->swap(packet_events_);
51 packet_events_.clear(); 48 packet_events_.clear();
52 } 49 }
53 50
54 void SimpleEventSubscriber::GetGenericEventsAndReset( 51 void SimpleEventSubscriber::GetGenericEventsAndReset(
55 std::vector<GenericEvent>* generic_events) { 52 std::vector<GenericEvent>* generic_events) {
56 thread_checker_.CalledOnValidThread(); 53 DCHECK(thread_checker_.CalledOnValidThread());
57 generic_events->swap(generic_events_); 54 generic_events->swap(generic_events_);
58 generic_events_.clear(); 55 generic_events_.clear();
59 } 56 }
60 57
61 } // namespace cast 58 } // namespace cast
62 } // namespace media 59 } // namespace media
OLDNEW
« no previous file with comments | « media/cast/logging/simple_event_subscriber.h ('k') | media/cast/logging/simple_event_subscriber_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698