Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: media/cast/logging/logging_raw_unittest.cc

Issue 145873007: Cast: Added missing DCHECKs to ThreadChecker calls and minor cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_ptr.h"
6 #include "base/test/simple_test_tick_clock.h"
7 #include "media/cast/logging/logging_defines.h" 5 #include "media/cast/logging/logging_defines.h"
8 #include "media/cast/logging/logging_raw.h" 6 #include "media/cast/logging/logging_raw.h"
9 #include "media/cast/logging/simple_event_subscriber.h" 7 #include "media/cast/logging/simple_event_subscriber.h"
10 #include "media/cast/test/fake_single_thread_task_runner.h"
11 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
12 9
13 namespace media { 10 namespace media {
14 namespace cast { 11 namespace cast {
15 12
16 class LoggingRawTest : public ::testing::Test { 13 class LoggingRawTest : public ::testing::Test {
17 protected: 14 protected:
18 LoggingRawTest() 15 LoggingRawTest() {
19 : task_runner_(new test::FakeSingleThreadTaskRunner(&testing_clock_)),
20 event_subscriber_(task_runner_) {
21 raw_.AddSubscriber(&event_subscriber_); 16 raw_.AddSubscriber(&event_subscriber_);
22 } 17 }
23 18
24 virtual ~LoggingRawTest() { raw_.RemoveSubscriber(&event_subscriber_); } 19 virtual ~LoggingRawTest() { raw_.RemoveSubscriber(&event_subscriber_); }
25 20
26 LoggingRaw raw_; 21 LoggingRaw raw_;
27 base::SimpleTestTickClock testing_clock_;
28 scoped_refptr<test::FakeSingleThreadTaskRunner> task_runner_;
29 SimpleEventSubscriber event_subscriber_; 22 SimpleEventSubscriber event_subscriber_;
30 std::vector<FrameEvent> frame_events_; 23 std::vector<FrameEvent> frame_events_;
31 std::vector<PacketEvent> packet_events_; 24 std::vector<PacketEvent> packet_events_;
32 std::vector<GenericEvent> generic_events_; 25 std::vector<GenericEvent> generic_events_;
33 }; 26 };
34 27
35 TEST_F(LoggingRawTest, FrameEvent) { 28 TEST_F(LoggingRawTest, FrameEvent) {
36 CastLoggingEvent event_type = kVideoFrameDecoded; 29 CastLoggingEvent event_type = kVideoFrameDecoded;
37 uint32 frame_id = 456u; 30 uint32 frame_id = 456u;
38 RtpTimestamp rtp_timestamp = 123u; 31 RtpTimestamp rtp_timestamp = 123u;
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 EXPECT_TRUE(packet_events_.empty()); 139 EXPECT_TRUE(packet_events_.empty());
147 140
148 event_subscriber_.GetGenericEventsAndReset(&generic_events_); 141 event_subscriber_.GetGenericEventsAndReset(&generic_events_);
149 ASSERT_EQ(1u, generic_events_.size()); 142 ASSERT_EQ(1u, generic_events_.size());
150 EXPECT_EQ(event_type, generic_events_[0].type); 143 EXPECT_EQ(event_type, generic_events_[0].type);
151 EXPECT_EQ(value, generic_events_[0].value); 144 EXPECT_EQ(value, generic_events_[0].value);
152 EXPECT_EQ(timestamp, generic_events_[0].timestamp); 145 EXPECT_EQ(timestamp, generic_events_[0].timestamp);
153 } 146 }
154 147
155 TEST_F(LoggingRawTest, MultipleSubscribers) { 148 TEST_F(LoggingRawTest, MultipleSubscribers) {
156 SimpleEventSubscriber event_subscriber_2(task_runner_); 149 SimpleEventSubscriber event_subscriber_2;
157 150
158 // Now raw_ has two subscribers. 151 // Now raw_ has two subscribers.
159 raw_.AddSubscriber(&event_subscriber_2); 152 raw_.AddSubscriber(&event_subscriber_2);
160 153
161 CastLoggingEvent event_type = kVideoFrameDecoded; 154 CastLoggingEvent event_type = kVideoFrameDecoded;
162 uint32 frame_id = 456u; 155 uint32 frame_id = 456u;
163 RtpTimestamp rtp_timestamp = 123u; 156 RtpTimestamp rtp_timestamp = 123u;
164 base::TimeTicks timestamp = base::TimeTicks(); 157 base::TimeTicks timestamp = base::TimeTicks();
165 raw_.InsertFrameEvent(timestamp, event_type, rtp_timestamp, frame_id); 158 raw_.InsertFrameEvent(timestamp, event_type, rtp_timestamp, frame_id);
166 159
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 EXPECT_EQ(timestamp, frame_events_[0].timestamp); 205 EXPECT_EQ(timestamp, frame_events_[0].timestamp);
213 EXPECT_EQ(event_type, frame_events_[0].type); 206 EXPECT_EQ(event_type, frame_events_[0].type);
214 EXPECT_EQ(base::TimeDelta(), frame_events_[0].delay_delta); 207 EXPECT_EQ(base::TimeDelta(), frame_events_[0].delay_delta);
215 208
216 event_subscriber_2.GetFrameEventsAndReset(&frame_events_); 209 event_subscriber_2.GetFrameEventsAndReset(&frame_events_);
217 EXPECT_TRUE(frame_events_.empty()); 210 EXPECT_TRUE(frame_events_.empty());
218 } 211 }
219 212
220 } // namespace cast 213 } // namespace cast
221 } // namespace media 214 } // namespace media
OLDNEW
« no previous file with comments | « media/cast/logging/logging_impl_unittest.cc ('k') | media/cast/logging/simple_event_subscriber.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698