More regular Platform implementations in unit tests (reland.)

More regular Platform implementations in unit tests (reland.)

R=haraken,jbroman
BUG=

Committed: https://crrev.com/6018759ce49b745a4a33d033815010e5aecf6987
Cr-Commit-Position: refs/heads/master@{#361030}

[sof, 2015-11-18 11:44:48]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, jbroman@chromium.org, tkent@chromium.org

[sof, 2015-11-18 11:44:48]

please take a look.

[haraken, 2015-11-18 11:50:35]

LGTM

[sof, 2015-11-18 12:14:27]

MSVC insists on transitive closure for BLINK_PLATFORM_EXPORTs, so had to add
that annotation to public/platform/Platform.h in ps#2.

[jbroman, 2015-11-18 15:00:56]

https://codereview.chromium.org/1456873003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/blink_platform.gypi (right):

https://codereview.chromium.org/1456873003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/blink_platform.gypi:122:
'TestingPlatformSupport.cpp',
Why does this have to move into the main platform component?

Could it, for instance, live in platform_test_support_files (which is linked
into both webkit_unit_tests and blink_platform_unittests, but not chrome)?

[jbroman, 2015-11-18 15:01:40]

On 2015/11/18 at 15:00:56, jbroman wrote:
>
https://codereview.chromium.org/1456873003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/blink_platform.gypi (right):
> 
>
https://codereview.chromium.org/1456873003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/blink_platform.gypi:122:
'TestingPlatformSupport.cpp',
> Why does this have to move into the main platform component?
> 
> Could it, for instance, live in platform_test_support_files (which is linked
into both webkit_unit_tests and blink_platform_unittests, but not chrome)?

(Aside: perhaps this file should also move to Source/platform/testing/, but I
won't make you do that in this CL.)

[sof, 2015-11-18 15:38:16]

https://codereview.chromium.org/1456873003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/blink_platform.gypi (right):

https://codereview.chromium.org/1456873003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/blink_platform.gypi:122:
'TestingPlatformSupport.cpp',
On 2015/11/18 15:00:56, jbroman wrote:
> Why does this have to move into the main platform component?
> 
> Could it, for instance, live in platform_test_support_files (which is linked
> into both webkit_unit_tests and blink_platform_unittests, but not chrome)?

Thanks for clueing me in, I was not aware that we could distinguish. There is no
need to offer TestingPlatformSupport outside of unit tests.

Having them in platform_test_support_files requires extending
export_dependent_settings with icu deps -- is that acceptable?

[jbroman, 2015-11-18 15:43:56]

On 2015/11/18 at 15:38:16, sigbjornf wrote:
>
https://codereview.chromium.org/1456873003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/blink_platform.gypi (right):
> 
>
https://codereview.chromium.org/1456873003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/blink_platform.gypi:122:
'TestingPlatformSupport.cpp',
> On 2015/11/18 15:00:56, jbroman wrote:
> > Why does this have to move into the main platform component?
> > 
> > Could it, for instance, live in platform_test_support_files (which is linked
> > into both webkit_unit_tests and blink_platform_unittests, but not chrome)?
> 
> Thanks for clueing me in, I was not aware that we could distinguish. There is
no need to offer TestingPlatformSupport outside of unit tests.
> 
> Having them in platform_test_support_files requires extending
export_dependent_settings with icu deps -- is that acceptable?

Seems fine (though I'm not sure I understand why moving TestingPlatformSupport
has that effect). lgtm

[sof, 2015-11-18 15:55:43]

On 2015/11/18 15:43:56, jbroman wrote:
> On 2015/11/18 at 15:38:16, sigbjornf wrote:
> >
>
https://codereview.chromium.org/1456873003/diff/40001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/platform/blink_platform.gypi (right):
> > 
> >
>
https://codereview.chromium.org/1456873003/diff/40001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/platform/blink_platform.gypi:122:
> 'TestingPlatformSupport.cpp',
> > On 2015/11/18 15:00:56, jbroman wrote:
> > > Why does this have to move into the main platform component?
> > > 
> > > Could it, for instance, live in platform_test_support_files (which is
linked
> > > into both webkit_unit_tests and blink_platform_unittests, but not chrome)?
> > 
> > Thanks for clueing me in, I was not aware that we could distinguish. There
is
> no need to offer TestingPlatformSupport outside of unit tests.
> > 
> > Having them in platform_test_support_files requires extending
> export_dependent_settings with icu deps -- is that acceptable?
> 
> Seems fine (though I'm not sure I understand why moving TestingPlatformSupport
> has that effect). lgtm

Hmm, there's some too eager inclusions of WTFString.h in platform/heap/ header
files which brings about the dependency (when compiling
TestingPlatformSupport.cpp). Let me tidy that up first & then we can avoid
adding it here.

[jbroman, 2015-11-18 16:00:26]

On 2015/11/18 at 15:55:43, sigbjornf wrote:
> On 2015/11/18 15:43:56, jbroman wrote:
> > On 2015/11/18 at 15:38:16, sigbjornf wrote:
> > >
> >
https://codereview.chromium.org/1456873003/diff/40001/third_party/WebKit/Sour...
> > > File third_party/WebKit/Source/platform/blink_platform.gypi (right):
> > > 
> > >
> >
https://codereview.chromium.org/1456873003/diff/40001/third_party/WebKit/Sour...
> > > third_party/WebKit/Source/platform/blink_platform.gypi:122:
> > 'TestingPlatformSupport.cpp',
> > > On 2015/11/18 15:00:56, jbroman wrote:
> > > > Why does this have to move into the main platform component?
> > > > 
> > > > Could it, for instance, live in platform_test_support_files (which is
linked
> > > > into both webkit_unit_tests and blink_platform_unittests, but not
chrome)?
> > > 
> > > Thanks for clueing me in, I was not aware that we could distinguish. There
is
> > no need to offer TestingPlatformSupport outside of unit tests.
> > > 
> > > Having them in platform_test_support_files requires extending
> > export_dependent_settings with icu deps -- is that acceptable?
> > 
> > Seems fine (though I'm not sure I understand why moving
TestingPlatformSupport
> > has that effect). lgtm
> 
> Hmm, there's some too eager inclusions of WTFString.h in platform/heap/ header
files which brings about the dependency (when compiling
TestingPlatformSupport.cpp). Let me tidy that up first & then we can avoid
adding it here.

Ah. I'll leave it up to you how to deal with that. It's not an unreasonable
dependency, given platform -> wtf/text -> ICU.

[sof, 2015-11-19 10:59:05]

Description was changed from

==========
More regular Platform implementations in unit tests.

R=
BUG=
==========

to

==========
More regular Platform implementations in unit tests.

R=haraken,jbroman
BUG=
==========

[sof, 2015-11-19 11:56:45]

About ready, but linux_chromium_compile_dbg_ng is running into a link error that
i'm trying to repro & understand the source of.

[sof, 2015-11-19 14:43:58]

On 2015/11/19 11:56:45, sof wrote:
> About ready, but linux_chromium_compile_dbg_ng is running into a link error
that
> i'm trying to repro & understand the source of.

Had to make webkit_unit_tests explicitly depend on wtf -- acceptable? ptal.

[jbroman, 2015-11-19 15:01:53]

On 2015/11/19 at 14:43:58, sigbjornf wrote:
> On 2015/11/19 11:56:45, sof wrote:
> > About ready, but linux_chromium_compile_dbg_ng is running into a link error
that
> > i'm trying to repro & understand the source of.
> 
> Had to make webkit_unit_tests explicitly depend on wtf -- acceptable? ptal.

Seems fine, given webkit_unit_tests does indeed use wtf. lgtm

[sof, 2015-11-19 15:03:54]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-11-19 15:03:54]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1456873003/#ps220001
(title: "GN counterpart..")

[commit-bot: I haz the power, 2015-11-19 15:04:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456873003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456873003/220001

[commit-bot: I haz the power, 2015-11-19 15:11:47]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2015-11-19 15:12:25]

Patchset 12 (id:??) landed as
https://crrev.com/3e197be3a60195ac2267f3293084fa36c5706503
Cr-Commit-Position: refs/heads/master@{#360583}

[grt (UTC plus 2), 2015-11-19 15:34:13]

A revert of this CL (patchset #12 id:220001) has been created in
https://codereview.chromium.org/1464493002/ by grt@chromium.org.

The reason for reverting is: Compile break on Win x64 Builder (dbg):

FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma/gomacc
"C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo
/showIncludes /FC
@obj\third_party\WebKit\Source\platform\testing\blink_platform_test_support.TestingPlatformSupport.obj.rsp
/c ..\..\third_party\WebKit\Source\platform\testing\TestingPlatformSupport.cpp
/Foobj\third_party\WebKit\Source\platform\testing\blink_platform_test_support.TestingPlatformSupport.obj
/Fdobj\third_party\WebKit\Source\platform\blink_platform_test_support.cc.pdb 
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\heap\heappage.h(188)
: error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\heap\heappage.h(188)
: warning C4267: '=' : conversion from 'size_t' to 'uint32_t', possible loss of
data
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\heap\heappage.h(202)
: warning C4267: '=' : conversion from 'size_t' to 'uint32_t', possible loss of
data
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\wtf\vector.h(654)
: warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss
of data
       
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\wtf\vector.h(644)
: while compiling class template member function
'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)'
       
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.cpp(38)
: see reference to function template instantiation
'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)' being compiled
       
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.h(55)
: see reference to class template instantiation
'WTF::Vector<char,0x00,WTF::PartitionAllocator>' being compiled
.

[sof, 2015-11-20 06:18:36]

Description was changed from

==========
More regular Platform implementations in unit tests.

R=haraken,jbroman
BUG=

Committed: https://crrev.com/3e197be3a60195ac2267f3293084fa36c5706503
Cr-Commit-Position: refs/heads/master@{#360583}
==========

to

==========
More regular Platform implementations in unit tests.

R=haraken,jbroman
BUG=
==========

[sof, 2015-11-20 06:20:01]

With the compilation issue separately taken care of (
https://codereview.chromium.org/1459933002/ ), relanding.

[sof, 2015-11-20 06:20:07]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-11-20 06:20:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456873003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456873003/220001

[commit-bot: I haz the power, 2015-11-20 06:24:53]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2015-11-20 06:25:54]

Patchset 12 (id:??) landed as
https://crrev.com/fd6f2835d66387788cc5c9f1025b6b0e7fcb6225
Cr-Commit-Position: refs/heads/master@{#360763}

[tkent, 2015-11-20 06:58:26]

On 2015/11/20 at 06:25:54, commit-bot wrote:
> Patchset 12 (id:??) landed as
https://crrev.com/fd6f2835d66387788cc5c9f1025b6b0e7fcb6225
> Cr-Commit-Position: refs/heads/master@{#360763}

Broke Win x64 build.

c:\b\build\slave\webkit-win-latest-rel-x64\build\src\third_party\webkit\source\wtf\vector.h(654)
: error C2220: warning treated as error - no 'object' file generated
       
c:\b\build\slave\webkit-win-latest-rel-x64\build\src\third_party\webkit\source\wtf\vector.h(644)
: while compiling class template member function
'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)'
       
c:\b\build\slave\webkit-win-latest-rel-x64\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.cpp(38)
: see reference to function template instantiation
'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)' being compiled
       
c:\b\build\slave\webkit-win-latest-rel-x64\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.h(55)
: see reference to class template instantiation
'WTF::Vector<char,0x00,WTF::PartitionAllocator>' being compiled
c:\b\build\slave\webkit-win-latest-rel-x64\build\src\third_party\webkit\source\wtf\vector.h(654)
: warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss
of data

blink_platform.gyp has:

    # Disable c4267 warnings until we fix size_t to int truncations.
    # Disable c4724 warnings which is generated in VS2012 due to improper
    # compiler optimizations, see crbug.com/237063
    'msvs_disabled_warnings': [ 4267, 4334, 4724 ],

[tkent, 2015-11-20 06:59:14]

A revert of this CL (patchset #12 id:220001) has been created in
https://codereview.chromium.org/1466603003/ by tkent@chromium.org.

The reason for reverting is: Broke Wind x64 build.
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Bui...
.

[sof, 2015-11-20 08:39:18]

Description was changed from

==========
More regular Platform implementations in unit tests.

R=haraken,jbroman
BUG=

Committed: https://crrev.com/fd6f2835d66387788cc5c9f1025b6b0e7fcb6225
Cr-Commit-Position: refs/heads/master@{#360763}
==========

to

==========
More regular Platform implementations in unit tests.

R=haraken,jbroman
BUG=

Committed: https://crrev.com/fd6f2835d66387788cc5c9f1025b6b0e7fcb6225
Cr-Commit-Position: refs/heads/master@{#360763}
==========

[sof, 2015-11-20 08:46:48]

Added required ignorance of MSVC's C4267 warning for blink_platform_test_support
-- TestingPlatformSupport now being a 'test support' file instead. May I ask for
(yet) another look, please? :)

Reproduced&verified locally with a Win64 build; I don't understand why the CQ
Win64 bots behave differently to "WebKit Win x64 Builder".

[sof, 2015-11-20 14:16:12]

Description was changed from

==========
More regular Platform implementations in unit tests.

R=haraken,jbroman
BUG=

Committed: https://crrev.com/fd6f2835d66387788cc5c9f1025b6b0e7fcb6225
Cr-Commit-Position: refs/heads/master@{#360763}
==========

to

==========
More regular Platform implementations in unit tests.

R=haraken,jbroman
BUG=
==========

[sof, 2015-11-20 21:54:01]

locally verified, relanding.

[sof, 2015-11-20 21:54:07]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-11-20 21:54:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1456873003/#ps240001
(title: "disable MSVC's C4267 for blink_platform_test_support")

[commit-bot: I haz the power, 2015-11-20 21:55:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456873003/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456873003/240001

[commit-bot: I haz the power, 2015-11-20 22:17:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 22:17:27]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sof, 2015-11-21 08:27:18]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-11-21 08:27:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1456873003/#ps260001
(title: "rebased")

[commit-bot: I haz the power, 2015-11-21 08:27:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456873003/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456873003/260001

[commit-bot: I haz the power, 2015-11-21 09:47:45]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2015-11-21 09:48:42]

Patchset 14 (id:??) landed as
https://crrev.com/81286531cd82370140d781f6daad585d44c1747c
Cr-Commit-Position: refs/heads/master@{#361019}

[tommi (sloooow) - chröme, 2015-11-21 16:29:38]

A revert of this CL (patchset #14 id:260001) has been created in
https://codereview.chromium.org/1464953003/ by tommi@chromium.org.

The reason for reverting is: Looks like this is causing build issues.  E.g.
http://build.chromium.org/p/chromium.win/waterfall?builder=Win%20x64%20GN%20(...

Example:
FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/WebKit/Source/platform/test_support/TestingPlatformSupport.obj.rsp
/c ../../third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp
/Foobj/third_party/WebKit/Source/platform/test_support/TestingPlatformSupport.obj
/Fdobj/third_party/WebKit/Source/platform/test_support_cc.pdb
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(654)
: error C2220: warning treated as error - no 'object' file generated
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(644)
: while compiling class template member function
'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)'
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.cpp(38)
: see reference to function template instantiation
'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)' being compiled
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.h(56)
: see reference to class template instantiation
'WTF::Vector<char,0x00,WTF::PartitionAllocator>' being compiled
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(654)
: warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss
of data
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(313)
: warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss
of data
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(306)
: while compiling class template member function 'void
WTF::VectorBufferBase<T,false,Allocator>::allocateBuffer(size_t)'
        with
        [
            T=char
,            Allocator=WTF::PartitionAllocator
        ]
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(386)
: see reference to function template instantiation 'void
WTF::VectorBufferBase<T,false,Allocator>::allocateBuffer(size_t)' being compiled
        with
        [
            T=char
,            Allocator=WTF::PartitionAllocator
        ]
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(373)
: see reference to class template instantiation
'WTF::VectorBufferBase<T,false,Allocator>' being compiled
        with
        [
            T=char
,            Allocator=WTF::PartitionAllocator
        ]
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(618)
: see reference to class template instantiation
'WTF::VectorBuffer<T,0x00,Allocator>' being compiled
        with
        [
            T=char
,            Allocator=WTF::PartitionAllocator
        ]
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(415)
: warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss
of data
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(411)
: while compiling class template member function 'bool
WTF::VectorBuffer<T,0x00,Allocator>::shrinkBuffer(size_t)'
        with
        [
            T=blink::Address
,            Allocator=WTF::PartitionAllocator
        ]
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1093)
: see reference to function template instantiation 'bool
WTF::VectorBuffer<T,0x00,Allocator>::shrinkBuffer(size_t)' being compiled
        with
        [
            T=blink::Address
,            Allocator=WTF::PartitionAllocator
        ]
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(618)
: see reference to class template instantiation
'WTF::VectorBuffer<T,0x00,Allocator>' being compiled
        with
        [
            T=blink::Address
,            Allocator=WTF::PartitionAllocator
        ]
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\platform\heap\threadstate.h(621)
: see reference to class template instantiation
'WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>' being compiled
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1024)
: warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss
of data
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1019)
: while compiling class template member function 'void
WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>::shrink(size_t)'
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1086)
: see reference to function template instantiation 'void
WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>::shrink(size_t)' being
compiled
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1081)
: while compiling class template member function 'void
WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>::shrinkCapacity(size_t)'
       
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(745)
: see reference to function template instantiation 'void
WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>::shrinkCapacity(size_t)'
being compiled
ninja: build stopped: subcommand failed.
.

[sof, 2015-11-21 18:01:16]

Description was changed from

==========
More regular Platform implementations in unit tests.

R=haraken,jbroman
BUG=

Committed: https://crrev.com/81286531cd82370140d781f6daad585d44c1747c
Cr-Commit-Position: refs/heads/master@{#361019}
==========

to

==========
More regular Platform implementations in unit tests (reland.)

R=haraken,jbroman
BUG=
==========

[sof, 2015-11-21 18:41:16]

Win64 GN failure addressed.

Details:

 - win_chromium_x64_rel_ng doesn't build any Blink unit tests; builds and runs
other unit test targets.
 - After the previous Win64 bot failure, I assumed it was GN-based and did
successfully build said unit tests. I was wrong.

Relanding; I will follow-up and file an issue asking for win_chromium_x64_rel_ng
to also include blink_tests. Not a major detour - it already builds Blink, if
needs be.

[sof, 2015-11-21 18:43:24]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-11-21 18:43:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1456873003/#ps280001
(title: "have GN disable c4267 also")

[commit-bot: I haz the power, 2015-11-21 18:43:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456873003/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456873003/280001

[commit-bot: I haz the power, 2015-11-21 19:37:05]

Committed patchset #15 (id:280001)

[commit-bot: I haz the power, 2015-11-21 19:37:54]

Patchset 15 (id:??) landed as
https://crrev.com/6018759ce49b745a4a33d033815010e5aecf6987
Cr-Commit-Position: refs/heads/master@{#361030}