Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1466603003: Revert of More regular Platform implementations in unit tests. (Closed)

Created:
5 years, 1 month ago by tkent
Modified:
5 years, 1 month ago
Reviewers:
haraken, sof, jbroman
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, Eric Willigers, f(malita), gavinp+loader_chromium.org, Nate Chapin, Justin Novosad, loading-reviews+fetch_chromium.org, pdr+graphicswatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, tyoshino+watch_chromium.org, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of More regular Platform implementations in unit tests. (patchset #12 id:220001 of https://codereview.chromium.org/1456873003/ ) Reason for revert: Broke Windows x64 build. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/67393 Original issue's description: > More regular Platform implementations in unit tests. > > R=haraken,jbroman > BUG= > > Committed: https://crrev.com/fd6f2835d66387788cc5c9f1025b6b0e7fcb6225 > Cr-Commit-Position: refs/heads/master@{#360763} TBR=jbroman@chromium.org,haraken@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/095b1f9385470384d4864d2e7ca92027e51c89cb Cr-Commit-Position: refs/heads/master@{#360770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+486 lines, -278 lines) Patch
M third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h View 2 chunks +23 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 4 chunks +23 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp View 4 chunks +27 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceTest.cpp View 4 chunks +41 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/PurgeableVectorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/SharedBufferTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/platform/TestingPlatformSupport.h View 1 chunk +81 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/TestingPlatformSupport.cpp View 1 chunk +105 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/TimerTest.cpp View 7 chunks +27 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCacheTest.cpp View 3 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 4 chunks +34 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/RunAllTests.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleMacTest.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/OriginAccessEntryTest.cpp View 3 chunks +26 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/ImageDecodeBench.cpp View 2 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TextFinderTest.cpp View 5 chunks +63 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/web_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
tkent
Created Revert of More regular Platform implementations in unit tests.
5 years, 1 month ago (2015-11-20 06:59:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466603003/1
5 years, 1 month ago (2015-11-20 07:00:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 07:04:00 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/095b1f9385470384d4864d2e7ca92027e51c89cb Cr-Commit-Position: refs/heads/master@{#360770}
5 years, 1 month ago (2015-11-20 07:05:11 UTC) #7
sof
lgtm.
5 years, 1 month ago (2015-11-20 07:07:04 UTC) #8
sof
it beggars belief though why Vector.h unsigned <-> size_t type mismatches should be flagged as ...
5 years, 1 month ago (2015-11-20 07:10:56 UTC) #9
haraken
5 years, 1 month ago (2015-11-20 08:04:52 UTC) #10
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698