Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1464493002: Revert of More regular Platform implementations in unit tests. (Closed)

Created:
5 years, 1 month ago by grt (UTC plus 2)
Modified:
5 years, 1 month ago
Reviewers:
haraken, tkent, sof, jbroman
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, Eric Willigers, f(malita), gavinp+loader_chromium.org, Nate Chapin, Justin Novosad, loading-reviews+fetch_chromium.org, pdr+graphicswatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, tyoshino+watch_chromium.org, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of More regular Platform implementations in unit tests. (patchset #12 id:220001 of https://codereview.chromium.org/1456873003/ ) Reason for revert: Compile break on Win x64 Builder (dbg): FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\third_party\WebKit\Source\platform\testing\blink_platform_test_support.TestingPlatformSupport.obj.rsp /c ..\..\third_party\WebKit\Source\platform\testing\TestingPlatformSupport.cpp /Foobj\third_party\WebKit\Source\platform\testing\blink_platform_test_support.TestingPlatformSupport.obj /Fdobj\third_party\WebKit\Source\platform\blink_platform_test_support.cc.pdb c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\heap\heappage.h(188) : error C2220: warning treated as error - no 'object' file generated c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\heap\heappage.h(188) : warning C4267: '=' : conversion from 'size_t' to 'uint32_t', possible loss of data c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\heap\heappage.h(202) : warning C4267: '=' : conversion from 'size_t' to 'uint32_t', possible loss of data c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\wtf\vector.h(654) : warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss of data c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\wtf\vector.h(644) : while compiling class template member function 'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)' c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.cpp(38) : see reference to function template instantiation 'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)' being compiled c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.h(55) : see reference to class template instantiation 'WTF::Vector<char,0x00,WTF::PartitionAllocator>' being compiled Original issue's description: > More regular Platform implementations in unit tests. > > R=haraken,jbroman > BUG= > > Committed: https://crrev.com/3e197be3a60195ac2267f3293084fa36c5706503 > Cr-Commit-Position: refs/heads/master@{#360583} TBR=jbroman@chromium.org,haraken@chromium.org,tkent@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/a1f9ec427ed75d7c0745d38f94cb462d08ae184e Cr-Commit-Position: refs/heads/master@{#360584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+486 lines, -278 lines) Patch
M third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h View 2 chunks +23 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 4 chunks +23 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp View 4 chunks +27 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceTest.cpp View 4 chunks +41 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/PurgeableVectorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/SharedBufferTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/platform/TestingPlatformSupport.h View 1 chunk +81 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/TestingPlatformSupport.cpp View 1 chunk +105 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/TimerTest.cpp View 7 chunks +27 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCacheTest.cpp View 3 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 4 chunks +34 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/RunAllTests.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleMacTest.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/OriginAccessEntryTest.cpp View 3 chunks +26 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/ImageDecodeBench.cpp View 2 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TextFinderTest.cpp View 5 chunks +63 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/web_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
grt (UTC plus 2)
Created Revert of More regular Platform implementations in unit tests.
5 years, 1 month ago (2015-11-19 15:34:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464493002/1
5 years, 1 month ago (2015-11-19 15:34:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 15:36:15 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a1f9ec427ed75d7c0745d38f94cb462d08ae184e Cr-Commit-Position: refs/heads/master@{#360584}
5 years, 1 month ago (2015-11-19 15:37:28 UTC) #4
sof
lgtm, thanks much for the revert. Odd error not caught by CQ bots.
5 years, 1 month ago (2015-11-19 15:44:25 UTC) #5
sof
On 2015/11/19 15:44:25, sof wrote: > lgtm, thanks much for the revert. Odd error not ...
5 years, 1 month ago (2015-11-19 16:07:21 UTC) #6
haraken
5 years, 1 month ago (2015-11-19 23:16:57 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698