third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp - Issue 1456873003: More regular Platform implementations in unit tests (reland.)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp

Issue 1456873003: More regular Platform implementations in unit tests (reland.) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: have GN disable c4267 also Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp ('k') | third_party/WebKit/Source/platform/testing/RunAllTests.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp b/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp

index c7800f795e970f4c43c61b82cb8fc1a7552cc53d..13487d835d657377cc8cd2af7d229436487fdd1a 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp

@@ -5,7 +5,7 @@

#include "config.h"

#include "platform/scroll/ScrollableArea.h"

-#include "platform/TestingPlatformSupport.h"

+#include "platform/testing/TestingPlatformSupport.h"

#include "public/platform/Platform.h"

#include "public/platform/WebScheduler.h"

#include "public/platform/WebThread.h"

@@ -86,7 +86,7 @@ public:

// We need just enough scaffolding for the Timer constructor to not segfault.

class FakePlatform : public TestingPlatformSupport {

public:

- FakePlatform() : TestingPlatformSupport(TestingPlatformSupport::Config()) { }

+ FakePlatform() { }

~FakePlatform() override { }

WebThread* currentThread() override