Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1464953003: Revert of More regular Platform implementations in unit tests (reland.) (Closed)

Created:
5 years ago by tommi (sloooow) - chröme
Modified:
5 years ago
Reviewers:
haraken, tkent, sof, jbroman
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, Eric Willigers, f(malita), gavinp+loader_chromium.org, Nate Chapin, Justin Novosad, loading-reviews+fetch_chromium.org, pdr+graphicswatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, tyoshino+watch_chromium.org, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of More regular Platform implementations in unit tests (reland.) (patchset #14 id:260001 of https://codereview.chromium.org/1456873003/ ) Reason for revert: Looks like this is causing build issues. E.g. http://build.chromium.org/p/chromium.win/waterfall?builder=Win%20x64%20GN%20(dbg) Example: FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/third_party/WebKit/Source/platform/test_support/TestingPlatformSupport.obj.rsp /c ../../third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp /Foobj/third_party/WebKit/Source/platform/test_support/TestingPlatformSupport.obj /Fdobj/third_party/WebKit/Source/platform/test_support_cc.pdb e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(654) : error C2220: warning treated as error - no 'object' file generated e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(644) : while compiling class template member function 'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)' e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.cpp(38) : see reference to function template instantiation 'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)' being compiled e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.h(56) : see reference to class template instantiation 'WTF::Vector<char,0x00,WTF::PartitionAllocator>' being compiled e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(654) : warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss of data e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(313) : warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss of data e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(306) : while compiling class template member function 'void WTF::VectorBufferBase<T,false,Allocator>::allocateBuffer(size_t)' with [ T=char , Allocator=WTF::PartitionAllocator ] e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(386) : see reference to function template instantiation 'void WTF::VectorBufferBase<T,false,Allocator>::allocateBuffer(size_t)' being compiled with [ T=char , Allocator=WTF::PartitionAllocator ] e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(373) : see reference to class template instantiation 'WTF::VectorBufferBase<T,false,Allocator>' being compiled with [ T=char , Allocator=WTF::PartitionAllocator ] e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(618) : see reference to class template instantiation 'WTF::VectorBuffer<T,0x00,Allocator>' being compiled with [ T=char , Allocator=WTF::PartitionAllocator ] e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(415) : warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss of data e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(411) : while compiling class template member function 'bool WTF::VectorBuffer<T,0x00,Allocator>::shrinkBuffer(size_t)' with [ T=blink::Address , Allocator=WTF::PartitionAllocator ] e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1093) : see reference to function template instantiation 'bool WTF::VectorBuffer<T,0x00,Allocator>::shrinkBuffer(size_t)' being compiled with [ T=blink::Address , Allocator=WTF::PartitionAllocator ] e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(618) : see reference to class template instantiation 'WTF::VectorBuffer<T,0x00,Allocator>' being compiled with [ T=blink::Address , Allocator=WTF::PartitionAllocator ] e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\platform\heap\threadstate.h(621) : see reference to class template instantiation 'WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>' being compiled e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1024) : warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss of data e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1019) : while compiling class template member function 'void WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>::shrink(size_t)' e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1086) : see reference to function template instantiation 'void WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>::shrink(size_t)' being compiled e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1081) : while compiling class template member function 'void WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>::shrinkCapacity(size_t)' e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(745) : see reference to function template instantiation 'void WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>::shrinkCapacity(size_t)' being compiled ninja: build stopped: subcommand failed. Original issue's description: > More regular Platform implementations in unit tests. > > R=haraken,jbroman > BUG= > > Committed: https://crrev.com/81286531cd82370140d781f6daad585d44c1747c > Cr-Commit-Position: refs/heads/master@{#361019} TBR=jbroman@chromium.org,haraken@chromium.org,tkent@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/a22a72fad19dd5deff2af11416470a8d0675f279 Cr-Commit-Position: refs/heads/master@{#361024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -286 lines) Patch
M third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h View 2 chunks +23 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 4 chunks +23 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp View 4 chunks +27 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceTest.cpp View 4 chunks +41 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/PurgeableVectorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/SharedBufferTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/platform/TestingPlatformSupport.h View 1 chunk +85 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/TestingPlatformSupport.cpp View 1 chunk +110 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/TimerTest.cpp View 7 chunks +27 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform_tests.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCacheTest.cpp View 3 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 4 chunks +34 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/RunAllTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 chunk +0 lines, -120 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleMacTest.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/OriginAccessEntryTest.cpp View 3 chunks +26 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ImageDecodeBench.cpp View 2 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TextFinderTest.cpp View 5 chunks +63 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/web_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tommi (sloooow) - chröme
Created Revert of More regular Platform implementations in unit tests (reland.)
5 years ago (2015-11-21 16:29:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464953003/1
5 years ago (2015-11-21 16:29:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-21 16:30:33 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a22a72fad19dd5deff2af11416470a8d0675f279 Cr-Commit-Position: refs/heads/master@{#361024}
5 years ago (2015-11-21 16:31:15 UTC) #4
sof
5 years ago (2015-11-21 16:35:40 UTC) #5
Message was sent while issue was closed.
hmm, lgtm. CQ coverage is sparse in this area.

Powered by Google App Engine
This is Rietveld 408576698