[Reland][Extensions] Don't count bubble focus loss as acknowledgment

[Reland][Extensions] Don't count bubble focus loss as acknowledgment

Currently, if an extension message bubble is shown, and then it is dismissed
because it loses focus, we treat it the same as the user clicking the dismiss
button - which serves as acknowledging the extension.  We could ignore focus
loss, but this makes for very noisy, awkward bubbles.  Instead, allow the bubble
to close, but don't treat this as user acknowledgment, and show the bubble again
on next startup.

This also involves tracking the close reason for a BubbleDelegateView.

BUG=548269
TBR=finnur@chromium.org (no changes relevant from original CL)
TBR=avi@chromium.org (no changes relevant from original CL)

Committed: https://crrev.com/486b20e71bb481cf6ae6491a998aa252081a8833
Cr-Commit-Position: refs/heads/master@{#360848}

[Devlin, 2015-11-18 23:17:11]

Description was changed from

==========
[Reland][Extensions] Don't count bubble focus loss as acknowledgment

Currently, if an extension message bubble is shown, and then it is dismissed
because it loses focus, we treat it the same as the user clicking the dismiss
button - which serves as acknowledging the extension.  We could ignore focus
loss, but this makes for very noisy, awkward bubbles.  Instead, allow the bubble
to close, but don't treat this as user acknowledgment, and show the bubble again
on next startup.

This also involves tracking the close reason for a BubbleDelegateView.

BUG=548269
TBR=finnur@chromium.org (no changes from original CL)
TBR=avi@chromium.org (no changes from original CL)
==========

to

==========
[Reland][Extensions] Don't count bubble focus loss as acknowledgment

Currently, if an extension message bubble is shown, and then it is dismissed
because it loses focus, we treat it the same as the user clicking the dismiss
button - which serves as acknowledging the extension.  We could ignore focus
loss, but this makes for very noisy, awkward bubbles.  Instead, allow the bubble
to close, but don't treat this as user acknowledgment, and show the bubble again
on next startup.

This also involves tracking the close reason for a BubbleDelegateView.

BUG=548269
(no changes relevant from original CL)
TBR=finnur@chromium.org
TBR=avi@chromium.org
==========

[Devlin, 2015-11-18 23:17:38]

Description was changed from

==========
[Reland][Extensions] Don't count bubble focus loss as acknowledgment

Currently, if an extension message bubble is shown, and then it is dismissed
because it loses focus, we treat it the same as the user clicking the dismiss
button - which serves as acknowledging the extension.  We could ignore focus
loss, but this makes for very noisy, awkward bubbles.  Instead, allow the bubble
to close, but don't treat this as user acknowledgment, and show the bubble again
on next startup.

This also involves tracking the close reason for a BubbleDelegateView.

BUG=548269
(no changes relevant from original CL)
TBR=finnur@chromium.org
TBR=avi@chromium.org
==========

to

==========
[Reland][Extensions] Don't count bubble focus loss as acknowledgment

Currently, if an extension message bubble is shown, and then it is dismissed
because it loses focus, we treat it the same as the user clicking the dismiss
button - which serves as acknowledging the extension.  We could ignore focus
loss, but this makes for very noisy, awkward bubbles.  Instead, allow the bubble
to close, but don't treat this as user acknowledgment, and show the bubble again
on next startup.

This also involves tracking the close reason for a BubbleDelegateView.

BUG=548269
(no changes relevant from original CL)
TBR=finnur@chromium.org,avi@chromium.org
==========

[Devlin, 2015-11-18 23:18:21]

Description was changed from

==========
[Reland][Extensions] Don't count bubble focus loss as acknowledgment

Currently, if an extension message bubble is shown, and then it is dismissed
because it loses focus, we treat it the same as the user clicking the dismiss
button - which serves as acknowledging the extension.  We could ignore focus
loss, but this makes for very noisy, awkward bubbles.  Instead, allow the bubble
to close, but don't treat this as user acknowledgment, and show the bubble again
on next startup.

This also involves tracking the close reason for a BubbleDelegateView.

BUG=548269
(no changes relevant from original CL)
TBR=finnur@chromium.org,avi@chromium.org
==========

to

==========
[Reland][Extensions] Don't count bubble focus loss as acknowledgment

Currently, if an extension message bubble is shown, and then it is dismissed
because it loses focus, we treat it the same as the user clicking the dismiss
button - which serves as acknowledging the extension.  We could ignore focus
loss, but this makes for very noisy, awkward bubbles.  Instead, allow the bubble
to close, but don't treat this as user acknowledgment, and show the bubble again
on next startup.

This also involves tracking the close reason for a BubbleDelegateView.

BUG=548269
TBR=finnur@chromium.org (no changes relevant from original CL)
TBR=avi@chromium.org (no changes relevant from original CL)
==========

[Devlin, 2015-11-18 23:21:26]

rdevlin.cronin@chromium.org changed reviewers:
+ sky@chromium.org
- avi@chromium.org (no changes from original cl), finnur@chromium.org (no
changes from original cl)

[Devlin, 2015-11-18 23:21:27]

Scott, mind taking a quick look?

https://codereview.chromium.org/1455313002/diff/20001/ui/views/bubble/bubble_...
File ui/views/bubble/bubble_delegate.cc (left):

https://codereview.chromium.org/1455313002/diff/20001/ui/views/bubble/bubble_...
ui/views/bubble/bubble_delegate.cc:53: BubbleDelegateView::BubbleDelegateView()
Grr... silly duplicate constructors.  We'll fix you!

Now using a delegating constructor so this doesn't happen again.

[sky, 2015-11-19 16:34:56]

LGTM

[Devlin, 2015-11-20 17:14:06]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-11-20 17:14:07]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1455313002/#ps40001
(title: "Latest master")

[commit-bot: I haz the power, 2015-11-20 17:14:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1455313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1455313002/40001

[commit-bot: I haz the power, 2015-11-20 17:20:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-20 17:21:18]

Patchset 3 (id:??) landed as
https://crrev.com/486b20e71bb481cf6ae6491a998aa252081a8833
Cr-Commit-Position: refs/heads/master@{#360848}