chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views_unittest.cc - Issue 1455313002: [Reland][Extensions] Don't count bubble focus loss as acknowledgment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views_unittest.cc

Issue 1455313002: [Reland][Extensions] Don't count bubble focus loss as acknowledgment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views.cc ('k') | ui/views/bubble/bubble_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views_unittest.cc

diff --git a/chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views_unittest.cc b/chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views_unittest.cc

index ab7cbd2bf2c700071c43c402d536ccebfa0a1775..ac8a6da64f0847c8625bcf9ddd57022c0145b9fa 100644

--- a/chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views_unittest.cc

+++ b/chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views_unittest.cc

@@ -81,11 +81,12 @@ TEST_F(ExtensionToolbarIconSurfacingBubbleTest,

views::test::TestWidgetObserver bubble_observer(bubble_widget);

EXPECT_FALSE(delegate.close_action());

- // Close the bubble. The delegate should be told it was dismissed.

- bubble_widget->Close();

+ // Close the bubble by activating another widget. The delegate should be

+ // told it was dismissed.

+ anchor_widget->Activate();

base::RunLoop().RunUntilIdle();

ASSERT_TRUE(delegate.close_action());

- EXPECT_EQ(ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS,

+ EXPECT_EQ(ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS_DEACTIVATION,

*delegate.close_action());

EXPECT_TRUE(bubble_observer.widget_closed());

}