Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4179)

Unified Diff: chrome/browser/extensions/settings_api_bubble_delegate.cc

Issue 1455313002: [Reland][Extensions] Don't count bubble focus loss as acknowledgment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/settings_api_bubble_delegate.cc
diff --git a/chrome/browser/extensions/settings_api_bubble_delegate.cc b/chrome/browser/extensions/settings_api_bubble_delegate.cc
index 2641883f200e1361a2539f2831b7068aaf5595df..26ac3da9c199b836e15b45a1de0f773173e857c1 100644
--- a/chrome/browser/extensions/settings_api_bubble_delegate.cc
+++ b/chrome/browser/extensions/settings_api_bubble_delegate.cc
@@ -238,4 +238,17 @@ void SettingsApiBubbleDelegate::LogAction(
}
}
+const char* SettingsApiBubbleDelegate::GetKey() {
+ switch (type_) {
+ case BUBBLE_TYPE_HOME_PAGE:
+ return "SettingsApiBubbleDelegate.HomePage";
+ case BUBBLE_TYPE_STARTUP_PAGES:
+ return "SettingsApiBubbleDelegate.StartupPages";
+ case BUBBLE_TYPE_SEARCH_ENGINE:
+ return "SettingsApiBubbleDelegate.SearchEngine";
+ }
+ NOTREACHED();
+ return "";
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698