chrome/browser/ui/views/extensions/extension_message_bubble_view.cc - Issue 1455313002: [Reland][Extensions] Don't count bubble focus loss as acknowledgment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

Issue 1455313002: [Reland][Extensions] Don't count bubble focus loss as acknowledgment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc ('k') | chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

index c30ba3bed5c8d0213470b5e26bcbaa744151fa1e..fc528bc07ab1614cdb6ea9f72465c069fb5e4dc9 100644

--- a/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

@@ -77,8 +77,10 @@ void ExtensionMessageBubbleView::Show() {

void ExtensionMessageBubbleView::OnWidgetDestroying(views::Widget* widget) {

// To catch Esc, we monitor destroy message. Unless the link has been clicked,

// we assume Dismiss was the action taken.

- if (!link_clicked_ && !action_taken_)

- controller_->OnBubbleDismiss();

+ if (!link_clicked_ && !action_taken_) {

+ bool closed_on_deactivation = close_reason() == CloseReason::DEACTIVATION;

+ controller_->OnBubbleDismiss(closed_on_deactivation);

+ }

}

void ExtensionMessageBubbleView::set_bubble_appearance_wait_time_for_testing(