chrome/browser/ui/cocoa/extensions/extension_message_bubble_bridge.mm - Issue 1455313002: [Reland][Extensions] Don't count bubble focus loss as acknowledgment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_message_bubble_bridge.mm

Issue 1455313002: [Reland][Extensions] Don't count bubble focus loss as acknowledgment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/suspicious_extension_bubble_delegate.cc ('k') | chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_message_bubble_bridge.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_message_bubble_bridge.mm b/chrome/browser/ui/cocoa/extensions/extension_message_bubble_bridge.mm

index 86f13617fcd8903efedd3f91ef62bca2721c5d5e..28b77e5e0f1fc63ab888fd0898afd97ca0672ace 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_message_bubble_bridge.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_message_bubble_bridge.mm

@@ -48,9 +48,12 @@ void ExtensionMessageBubbleBridge::OnBubbleShown() {

void ExtensionMessageBubbleBridge::OnBubbleClosed(CloseAction action) {

switch(action) {

- case CLOSE_DISMISS:

- controller_->OnBubbleDismiss();

+ case CLOSE_DISMISS_USER_ACTION:

+ case CLOSE_DISMISS_DEACTIVATION: {

+ bool close_by_deactivate = action == CLOSE_DISMISS_DEACTIVATION;

+ controller_->OnBubbleDismiss(close_by_deactivate);

break;

+ }

case CLOSE_EXECUTE:

controller_->OnBubbleAction();

break;