Convert remaining RenderSVG* nodes to RenderObject::isChildAllowed

Convert remaining RenderSVG* nodes to RenderObject::isChildAllowed

Reland of:
r165851 (https://codereview.chromium.org/146833003) and
r166238 (https://codereview.chromium.org/136963005)

Performance issues should have been adressed by the latter.

BUG=337607
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166705

[fs, 2014-02-05 17:19:49]

OK to reland this change (+fixup)?

If you'd like to check the perf-dashboard, the revert was Blink r166392 (not a
band).

[rwlbuis, 2014-02-06 18:53:20]

Looks good but I think some changes are not needed.

https://codereview.chromium.org/145333003/diff/1/Source/core/svg/SVGAElement.h
File Source/core/svg/SVGAElement.h (right):

https://codereview.chromium.org/145333003/diff/1/Source/core/svg/SVGAElement....
Source/core/svg/SVGAElement.h:59: virtual bool childShouldCreateRenderer(const
Node& child) const OVERRIDE { return true; }
I don't think you need this override since SVGElement already returns true.

https://codereview.chromium.org/145333003/diff/1/Source/core/svg/SVGSwitchEle...
File Source/core/svg/SVGSwitchElement.h (right):

https://codereview.chromium.org/145333003/diff/1/Source/core/svg/SVGSwitchEle...
Source/core/svg/SVGSwitchElement.h:38: virtual bool
childShouldCreateRenderer(const Node& child) const OVERRIDE { return true; }
I don't think you need this override since SVGElement already returns true.

[Stephen Chennney, 2014-02-06 21:09:34]

LGTM with Rob's nits. I think that SVGElement is the only thing that should
define childShouldCreateRenderer, as the method is about to go away and
everything has been converted. Right?

[fs, 2014-02-07 08:11:13]

On 2014/02/06 21:09:34, Stephen Chenney wrote:
> LGTM with Rob's nits. I think that SVGElement is the only thing that should
> define childShouldCreateRenderer, as the method is about to go away and
> everything has been converted. Right?

A have a patch pending that would slay them all and remove the method. I can
initiate the slaying early though by rolling up these two.

[fs, 2014-02-07 08:17:58]

https://codereview.chromium.org/145333003/diff/1/Source/core/svg/SVGAElement.h
File Source/core/svg/SVGAElement.h (right):

https://codereview.chromium.org/145333003/diff/1/Source/core/svg/SVGAElement....
Source/core/svg/SVGAElement.h:59: virtual bool childShouldCreateRenderer(const
Node& child) const OVERRIDE { return true; }
On 2014/02/06 18:53:20, rwlbuis wrote:
> I don't think you need this override since SVGElement already returns true.

Done.

https://codereview.chromium.org/145333003/diff/1/Source/core/svg/SVGSwitchEle...
File Source/core/svg/SVGSwitchElement.h (right):

https://codereview.chromium.org/145333003/diff/1/Source/core/svg/SVGSwitchEle...
Source/core/svg/SVGSwitchElement.h:38: virtual bool
childShouldCreateRenderer(const Node& child) const OVERRIDE { return true; }
On 2014/02/06 18:53:20, rwlbuis wrote:
> I don't think you need this override since SVGElement already returns true.

Done.

[fs, 2014-02-07 11:49:38]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-02-07 11:49:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/145333003/130001

[commit-bot: I haz the power, 2014-02-07 12:15:24]

Change committed as 166705