Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Side by Side Diff: Source/core/svg/SVGElement.cpp

Issue 145333003: Convert remaining RenderSVG* nodes to RenderObject::isChildAllowed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove some instances of childShouldCreateRenderer. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGElement.h ('k') | Source/core/svg/SVGSwitchElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org> 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>
3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 5 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 932 matching lines...) Expand 10 before | Expand all | Expand 10 after
943 // The outermost SVGSVGElement SVGLoad event is fired through Document::disp atchWindowLoadEvent. 943 // The outermost SVGSVGElement SVGLoad event is fired through Document::disp atchWindowLoadEvent.
944 if (isOutermostSVGSVGElement()) 944 if (isOutermostSVGSVGElement())
945 return; 945 return;
946 946
947 // finishParsingChildren() is called when the close tag is reached for an el ement (e.g. </svg>) 947 // finishParsingChildren() is called when the close tag is reached for an el ement (e.g. </svg>)
948 // we send SVGLoad events here if we can, otherwise they'll be sent when any required loads finish 948 // we send SVGLoad events here if we can, otherwise they'll be sent when any required loads finish
949 if (isSVGSVGElement()) 949 if (isSVGSVGElement())
950 sendSVGLoadEventIfPossible(); 950 sendSVGLoadEventIfPossible();
951 } 951 }
952 952
953 bool SVGElement::childShouldCreateRenderer(const Node& child) const
954 {
955 if (child.hasTagName(SVGNames::textPathTag)
956 #if ENABLE(SVG_FONTS)
957 || child.hasTagName(SVGNames::altGlyphTag)
958 #endif
959 || child.hasTagName(SVGNames::tspanTag))
960 return false;
961 return child.isSVGElement();
962 }
963
964 void SVGElement::attributeChanged(const QualifiedName& name, const AtomicString& newValue, AttributeModificationReason) 953 void SVGElement::attributeChanged(const QualifiedName& name, const AtomicString& newValue, AttributeModificationReason)
965 { 954 {
966 Element::attributeChanged(name, newValue); 955 Element::attributeChanged(name, newValue);
967 956
968 if (isIdAttributeName(name)) 957 if (isIdAttributeName(name))
969 document().accessSVGExtensions()->rebuildAllElementReferencesForTarget(t his); 958 document().accessSVGExtensions()->rebuildAllElementReferencesForTarget(t his);
970 959
971 // Changes to the style attribute are processed lazily (see Element::getAttr ibute() and related methods), 960 // Changes to the style attribute are processed lazily (see Element::getAttr ibute() and related methods),
972 // so we don't want changes to the style attribute to result in extra work h ere. 961 // so we don't want changes to the style attribute to result in extra work h ere.
973 if (name != HTMLNames::styleAttr) 962 if (name != HTMLNames::styleAttr)
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
1200 animatableAttributes.add(SVGNames::zAttr); 1189 animatableAttributes.add(SVGNames::zAttr);
1201 } 1190 }
1202 1191
1203 if (name == classAttr) 1192 if (name == classAttr)
1204 return true; 1193 return true;
1205 1194
1206 return animatableAttributes.contains(name); 1195 return animatableAttributes.contains(name);
1207 } 1196 }
1208 #endif 1197 #endif
1209 } 1198 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGElement.h ('k') | Source/core/svg/SVGSwitchElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698