Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 146833003: Convert remaining RenderSVG* nodes to RenderObject::isChildAllowed (Closed)

Created:
6 years, 11 months ago by fs
Modified:
6 years, 10 months ago
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Convert remaining RenderSVG* nodes to RenderObject::isChildAllowed BUG=337607 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165851

Patch Set 1 #

Patch Set 2 : Fix 'switch' condition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -46 lines) Patch
M Source/core/rendering/svg/RenderSVGInline.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTransformableContainer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTransformableContainer.cpp View 1 1 chunk +31 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSwitchElement.cpp View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Stephen Chennney
lgtm
6 years, 11 months ago (2014-01-24 18:07:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/146833003/40001
6 years, 11 months ago (2014-01-24 18:07:26 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=23998
6 years, 11 months ago (2014-01-24 20:51:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/146833003/40001
6 years, 10 months ago (2014-01-27 14:23:24 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-27 14:23:53 UTC) #5
Message was sent while issue was closed.
Change committed as 165851

Powered by Google App Engine
This is Rietveld 408576698