Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 136963005: Implement canHaveWhitespaceChildren on RenderSVG{Root,ModelObject} (Closed)

Created:
6 years, 10 months ago by fs
Modified:
6 years, 10 months ago
Reviewers:
pdr., f(malita), schenney, fmalita_google_do_not_use
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Implement canHaveWhitespaceChildren on RenderSVG{Root,ModelObject} Make said method return false to signal that we don't care about whitespace-only Nodes in these contexts. This avoids creating large number of text RenderObjects (RenderSVGInlineTexts) and also avoids hitting the linear search at the bottom of Text::textRendererIsNeeded. R=pdr,schenney,fmalita BUG=339470, 337607 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/rendering/svg/RenderSVGModelObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
fs
6 years, 10 months ago (2014-01-31 15:35:09 UTC) #1
f(malita)
lgtm
6 years, 10 months ago (2014-01-31 15:45:22 UTC) #2
fs
The CQ bit was checked by fs@opera.com
6 years, 10 months ago (2014-01-31 17:14:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/136963005/1
6 years, 10 months ago (2014-01-31 17:14:37 UTC) #4
commit-bot: I haz the power
Change committed as 166238
6 years, 10 months ago (2014-01-31 19:51:28 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 19:51:32 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 19:51:34 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 19:51:35 UTC) #8
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698