Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: Source/core/svg/SVGSwitchElement.cpp

Issue 145333003: Convert remaining RenderSVG* nodes to RenderObject::isChildAllowed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove some instances of childShouldCreateRenderer. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGSwitchElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 30 matching lines...) Expand all
41 registerAnimatedPropertiesForSVGSwitchElement(); 41 registerAnimatedPropertiesForSVGSwitchElement();
42 42
43 UseCounter::count(document, UseCounter::SVGSwitchElement); 43 UseCounter::count(document, UseCounter::SVGSwitchElement);
44 } 44 }
45 45
46 PassRefPtr<SVGSwitchElement> SVGSwitchElement::create(Document& document) 46 PassRefPtr<SVGSwitchElement> SVGSwitchElement::create(Document& document)
47 { 47 {
48 return adoptRef(new SVGSwitchElement(document)); 48 return adoptRef(new SVGSwitchElement(document));
49 } 49 }
50 50
51 bool SVGSwitchElement::childShouldCreateRenderer(const Node& child) const
52 {
53 // FIXME: This function does not do what the comment below implies it does.
54 // It will create a renderer for any valid SVG element children, not just th e first one.
55 bool shouldCreateRenderer = false;
56 for (Node* node = firstChild(); node; node = node->nextSibling()) {
57 if (!node->isSVGElement())
58 continue;
59
60 SVGElement* element = toSVGElement(node);
61 if (!element || !element->isValid())
62 continue;
63
64 shouldCreateRenderer = node == &child; // Only allow this child if it's the first valid child.
65 break;
66 }
67
68 return shouldCreateRenderer && SVGGraphicsElement::childShouldCreateRenderer (child);
69 }
70
71 RenderObject* SVGSwitchElement::createRenderer(RenderStyle*) 51 RenderObject* SVGSwitchElement::createRenderer(RenderStyle*)
72 { 52 {
73 return new RenderSVGTransformableContainer(this); 53 return new RenderSVGTransformableContainer(this);
74 } 54 }
75 55
76 } 56 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGSwitchElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698