Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1453113002: Handle StepIn for constructors through PrepareStep just like for regular calls (Closed)

Created:
5 years, 1 month ago by Toon Verwaest
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Handle StepIn for constructors through PrepareStep just like for regular calls BUG= Committed: https://crrev.com/14ec485c3a2887af22e17fb3906215d9a02f5e83 Cr-Commit-Position: refs/heads/master@{#32044}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Add ports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -180 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 4 2 chunks +0 lines, -25 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 3 4 2 chunks +0 lines, -20 lines 0 comments Download
M src/assembler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/debug/debug.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug/debug.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 3 3 chunks +6 lines, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 3 4 2 chunks +0 lines, -21 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 3 4 2 chunks +0 lines, -20 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 3 4 2 chunks +0 lines, -21 lines 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
lgtm. A lot cleaner now!
5 years, 1 month ago (2015-11-17 12:58:23 UTC) #2
Yang
ports lgtm.
5 years, 1 month ago (2015-11-17 13:19:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453113002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453113002/80001
5 years, 1 month ago (2015-11-17 13:24:29 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 1 month ago (2015-11-17 14:02:56 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 14:03:38 UTC) #7
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/14ec485c3a2887af22e17fb3906215d9a02f5e83
Cr-Commit-Position: refs/heads/master@{#32044}

Powered by Google App Engine
This is Rietveld 408576698