Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: src/assembler.cc

Issue 1453113002: Handle StepIn for constructors through PrepareStep just like for regular calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add ports Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/builtins-arm64.cc ('k') | src/debug/debug.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 503 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 } 514 }
515 next_position_candidate_flushed_ = false; 515 next_position_candidate_flushed_ = false;
516 } 516 }
517 last_position_ = static_cast<int>(rinfo->data()); 517 last_position_ = static_cast<int>(rinfo->data());
518 } else { 518 } else {
519 WriteModeAndPC(pc_delta, rmode); 519 WriteModeAndPC(pc_delta, rmode);
520 if (RelocInfo::IsComment(rmode)) { 520 if (RelocInfo::IsComment(rmode)) {
521 WriteData(rinfo->data()); 521 WriteData(rinfo->data());
522 } else if (RelocInfo::IsConstPool(rmode) || 522 } else if (RelocInfo::IsConstPool(rmode) ||
523 RelocInfo::IsVeneerPool(rmode) || 523 RelocInfo::IsVeneerPool(rmode) ||
524 RelocInfo::IsDebugBreakSlotAtCall(rmode)) { 524 RelocInfo::IsDebugBreakSlotAtCall(rmode) ||
525 RelocInfo::IsDebugBreakSlotAtConstructCall(rmode)) {
525 WriteIntData(static_cast<int>(rinfo->data())); 526 WriteIntData(static_cast<int>(rinfo->data()));
526 } 527 }
527 } 528 }
528 last_pc_ = rinfo->pc(); 529 last_pc_ = rinfo->pc();
529 last_mode_ = rmode; 530 last_mode_ = rmode;
530 #ifdef DEBUG 531 #ifdef DEBUG
531 DCHECK(begin_pos - pos_ <= kMaxSize); 532 DCHECK(begin_pos - pos_ <= kMaxSize);
532 #endif 533 #endif
533 } 534 }
534 535
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
706 if (mode_mask_ & RelocInfo::kPositionMask) { 707 if (mode_mask_ & RelocInfo::kPositionMask) {
707 // Always update the position if we are interested in either 708 // Always update the position if we are interested in either
708 // statement positions or non-statement positions. 709 // statement positions or non-statement positions.
709 AdvanceReadPosition(); 710 AdvanceReadPosition();
710 if (SetMode(rmode)) return; 711 if (SetMode(rmode)) return;
711 } else { 712 } else {
712 Advance(kIntSize); 713 Advance(kIntSize);
713 } 714 }
714 } else if (RelocInfo::IsConstPool(rmode) || 715 } else if (RelocInfo::IsConstPool(rmode) ||
715 RelocInfo::IsVeneerPool(rmode) || 716 RelocInfo::IsVeneerPool(rmode) ||
716 RelocInfo::IsDebugBreakSlotAtCall(rmode)) { 717 RelocInfo::IsDebugBreakSlotAtCall(rmode) ||
718 RelocInfo::IsDebugBreakSlotAtConstructCall(rmode)) {
717 if (SetMode(rmode)) { 719 if (SetMode(rmode)) {
718 AdvanceReadInt(); 720 AdvanceReadInt();
719 return; 721 return;
720 } 722 }
721 Advance(kIntSize); 723 Advance(kIntSize);
722 } else if (SetMode(static_cast<RelocInfo::Mode>(rmode))) { 724 } else if (SetMode(static_cast<RelocInfo::Mode>(rmode))) {
723 return; 725 return;
724 } 726 }
725 } 727 }
726 } 728 }
(...skipping 1173 matching lines...) Expand 10 before | Expand all | Expand 10 after
1900 1902
1901 1903
1902 void Assembler::DataAlign(int m) { 1904 void Assembler::DataAlign(int m) {
1903 DCHECK(m >= 2 && base::bits::IsPowerOfTwo32(m)); 1905 DCHECK(m >= 2 && base::bits::IsPowerOfTwo32(m));
1904 while ((pc_offset() & (m - 1)) != 0) { 1906 while ((pc_offset() & (m - 1)) != 0) {
1905 db(0); 1907 db(0);
1906 } 1908 }
1907 } 1909 }
1908 } // namespace internal 1910 } // namespace internal
1909 } // namespace v8 1911 } // namespace v8
OLDNEW
« no previous file with comments | « src/arm64/builtins-arm64.cc ('k') | src/debug/debug.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698